Remove tuple-store INSERT EXEC implementation#771
Open
monk0707 wants to merge 1 commit into
Open
Conversation
…plete new redesign approach implemented
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the old tuple-store based INSERT EXEC implementation from the engine side. The INSERT EXEC feature has been reimplemented using a DestReceiver-based approach in the extension side.
Changes:
called_from_tsql_insert_exec_hook_typetypedef fromsrc/include/access/attmap.hcalled_from_tsql_insert_exec_hookextern declaration fromattmap.hcalled_from_tsql_insert_exec_hookvariable fromsrc/backend/access/common/attmap.cattmap.ctype checking logicsrc/backend/access/common/tupconvert.cvalue casting logicsrc/backend/executor/nodeModifyTable.c(~60 lines)Why:
The new DestReceiver-based approach:
The old engine-side hooks are no longer needed.
Related Extension PR: babelfish-for-postgresql/babelfish_extensions#4856
Issues Resolved
Cleanup of deprecated INSERT EXEC engine hooks as part of the DestReceiver-based INSERT EXEC reimplementation.
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.