Adding bbf version of pgstat_init_function_usage#772
Open
RuchaSK1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rucha Kulkarni <ruchask@amazon.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding pgstat_init_function_usage_no_drop, a Babelfish-specific version of pgstat_init_function_usage that does not call pgstat_drop_entry when a function is found to be concurrently dropped. This prevents a server crash caused by double-drop of pgstat entries during concurrent DROP+CREATE+EXEC with track_functions=all.
Changing pgstat_function_wrapper_hook return type from void to bool to allow the hook to skip the engine's pgstat_init_function_usage.
Extension PR: babelfish-for-postgresql/babelfish_extensions#4859
Issues Resolved
Task: BABEL-6405
Authored-by: Rucha Kulkarni ruchask@amazon.com
Signed-off-by: Rucha Kulkarni ruchask@amazon.com
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.