Handle Long Identifiers for Babelfish#773
Open
anju15bharti wants to merge 1 commit into
Open
Conversation
abf8aff to
fed7432
Compare
1 task
a07674e to
7e4fb80
Compare
Contributor
Author
|
/code-review |
Signed-off-by: anju15bharti <abanju@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Engine-side changes to support long identifier handling in Babelfish.
New hooks (
bbf_get_original_constraint_name_hook,bbf_get_original_index_name_hook) allow the extension to resolve original constraint/index names in unique violation and check constraint error messages.tle_name_comparison_hookextended withsourcetextandlocationparameters so ORDER BY clauses can match long column aliases by extracting the full identifier from the raw query text.View column truncation — When
sql_dialect == SQL_DIALECT_TSQLand a view column name exceedsNAMEDATALEN, it is MD5-truncated before storage inpg_attribute.Rule rewrite tolerance —
checkRuleResultListinrewriteDefine.cnow allows a long SELECT column name to match its truncatedattnamecounterpart for TSQL views.Dump support —
babelfish_identifier_mappingadded to logical and physical dump paths.Syscache —
IDENTMAPPINGNAMEregistered for the new identifier mapping catalogExtension PR : babelfish-for-postgresql/babelfish_extensions#4866
Issues Resolved
BABEL-2564, BABEL-5975, BABEL-5321, BABEL-2650, BABEL-6817, BABEL-1518, BABEL-5207, BABEL-5650, BABEL-5416, BABEL-1519
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.