Add network_interface option to bind outgoing HTTP requests to a spec…#286
Open
mmarwah wants to merge 1 commit intobabelouest:masterfrom
Open
Add network_interface option to bind outgoing HTTP requests to a spec…#286mmarwah wants to merge 1 commit intobabelouest:masterfrom
mmarwah wants to merge 1 commit intobabelouest:masterfrom
Conversation
mnjdhl
reviewed
Apr 20, 2026
| o_free(request->http_url); | ||
| o_free(request->url_path); | ||
| o_free(request->proxy); | ||
| o_free(request->network_interface); |
There was a problem hiding this comment.
Null check is not required before free?
Author
There was a problem hiding this comment.
Null check is done in o_free().
https://github.com/babelouest/orcania/blob/master/src/memory.c#L35
Owner
|
Hello, Although I understand the need, I'm not sure it's a good idea to add libcurl options that are not "mainstream". My future self would have difficulties to maintain too much options that are not used so much... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary