Commit f997a6e
Jony Bursztyn
feat: hooks first architecture (#563)
* docs(packages): add vault architecture documentation
- Add comprehensive architecture options documentation
- Compare Clean Layers, Feature Modules, and Hooks-First approaches
- Document decision framework and migration strategies
- Choose Hooks-First architecture for implementation
* feat(packages): add pure service functions for deposit flow
- Create calculations service for deposit fees and UTXO selection
- Add validation functions with consistent result format
- Implement data transformers for deposit operations
- Extract business logic from components into pure functions
* feat(packages): implement business logic hooks for deposits
- Add main deposit flow orchestration hook
- Create validation hook with UTXO and balance checks
- Implement transaction creation and submission hook
- Separate business logic from UI components using hooks pattern
* docs(packages): add migration guide for hooks-first architecture
- Provide step-by-step migration instructions
- Include code examples for common patterns
- Add testing strategy for each layer
- Document benefits and next steps for team adoption
* fix(packages): resolve TypeScript errors in deposit hooks
- Fix undefined type check in useDepositFlow
- Remove unused imports and variables
- Correct LocalStorageStatus enum values in transformers
- Update PeginDisplayLabel types to match state machine
* fix(packages): improve parseBtcToSatoshis input validation
- Handle empty strings and edge cases properly
- Validate decimal point count (prevent multiple decimals)
- Handle strings with only decimals (e.g., '.5')
- Add regex validation for final satoshi string
- Return 0n for invalid inputs instead of throwing
* fix(packages): prevent precision loss in formatSatoshisToBtc
- Use bigint arithmetic throughout instead of Number conversion
- Avoid precision loss for values >= 2^53
- Handle fractional part with string padding and trimming
- Maintain correct decimal place handling
* docs(packages): add merge architecture compliance report
- Analyze code merged from main against new architecture
- Verify all changes are compliant with hooks-first pattern
- Document positive patterns (error utilities, useBorrowUI)
- Identify areas for future migration
- Provide integration recommendations
* style(packages): fix linter errors in deposit hooks
- Run prettier to fix formatting issues
- Fix import ordering
- Remove unused variables
- Standardize quote styles to double quotes
* feat(packages): updates
* feat(packages): remove files
* feat(packages): tests fixes
* feat(packages): improvements
* feat(packages): linter
* feat(packages): revisions
* feat(packages): revisions
* feat(packages): revisions
* feat(packages): revisions
* feat(packages): fix pnpm
* feat(packages): fix lint
* feat(packages): fixes
* feat(packages): fixes
* feat(packages): lint
* feat(packages): lint
* feat(packages): lint
* feat(packages): lint
* feat(packages): switch network
* feat(packages): add tests
* feat(packages): add tests
* feat(packages): lint1 parent cdca97a commit f997a6e
33 files changed
Lines changed: 4639 additions & 634 deletions
File tree
- services/vault
- src
- components/Overview
- Deposits
- DepositFormModal
- DepositOverview
- DepositSignModal
- hooks
- state
- hooks/deposit
- __tests__
- services/deposit
- __tests__
- test
- utils
- errors
- __tests__
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
16 | 20 | | |
17 | 21 | | |
18 | 22 | | |
| |||
75 | 79 | | |
76 | 80 | | |
77 | 81 | | |
78 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
79 | 85 | | |
80 | 86 | | |
Lines changed: 61 additions & 61 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
| 15 | + | |
| 16 | + | |
21 | 17 | | |
22 | 18 | | |
23 | 19 | | |
| |||
31 | 27 | | |
32 | 28 | | |
33 | 29 | | |
34 | | - | |
| 30 | + | |
35 | 31 | | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | 32 | | |
42 | 33 | | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
| 34 | + | |
47 | 35 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
54 | 53 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
62 | 57 | | |
| 58 | + | |
63 | 59 | | |
64 | | - | |
65 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
66 | 65 | | |
67 | | - | |
68 | | - | |
69 | | - | |
| 66 | + | |
70 | 67 | | |
71 | 68 | | |
72 | 69 | | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
78 | 75 | | |
79 | 76 | | |
80 | 77 | | |
81 | 78 | | |
82 | | - | |
| 79 | + | |
83 | 80 | | |
84 | 81 | | |
85 | 82 | | |
86 | 83 | | |
87 | 84 | | |
88 | | - | |
| 85 | + | |
| 86 | + | |
89 | 87 | | |
90 | 88 | | |
91 | 89 | | |
92 | 90 | | |
93 | 91 | | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
111 | | - | |
| 110 | + | |
112 | 111 | | |
113 | 112 | | |
114 | 113 | | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
115 | 121 | | |
116 | 122 | | |
117 | 123 | | |
| |||
125 | 131 | | |
126 | 132 | | |
127 | 133 | | |
128 | | - | |
| 134 | + | |
129 | 135 | | |
130 | 136 | | |
131 | 137 | | |
| |||
144 | 150 | | |
145 | 151 | | |
146 | 152 | | |
147 | | - | |
| 153 | + | |
148 | 154 | | |
149 | 155 | | |
150 | 156 | | |
| |||
170 | 176 | | |
171 | 177 | | |
172 | 178 | | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
| 179 | + | |
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
186 | | - | |
| 186 | + | |
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
195 | | - | |
| 195 | + | |
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
| 204 | + | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
216 | | - | |
| 216 | + | |
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
| |||
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
32 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
335 | 335 | | |
336 | 336 | | |
337 | 337 | | |
338 | | - | |
| 338 | + | |
339 | 339 | | |
340 | 340 | | |
341 | 341 | | |
| |||
344 | 344 | | |
345 | 345 | | |
346 | 346 | | |
347 | | - | |
| 347 | + | |
348 | 348 | | |
349 | 349 | | |
350 | 350 | | |
| |||
0 commit comments