Skip to content

feat(vault): new onboarding checkboxes for wallet#1668

Draft
jonybur wants to merge 2 commits into
mainfrom
feat/new-onboarding-wallet
Draft

feat(vault): new onboarding checkboxes for wallet#1668
jonybur wants to merge 2 commits into
mainfrom
feat/new-onboarding-wallet

Conversation

@jonybur
Copy link
Copy Markdown
Contributor

@jonybur jonybur commented May 14, 2026

(this is a wip, not ready for review)

@jonybur jonybur changed the title feat(vault): new onboarding for wallet feat(vault): new onboarding checkboxes for wallet May 14, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

🔐 Commit Signature Verification

All 2 commit(s) passed verification

Commit Author Signature Key Type Key Check
730b139eb687 Jonathan Bursztyn sk-ssh-ed25519
3c601230240b Jonathan Bursztyn sk-ssh-ed25519

Summary

  • Commits verified: 2
  • Signature check: ✅ All passed
  • Key type enforcement: ✅ All sk-ssh-ed25519

Required key type: sk-ssh-ed25519 (FIDO2 hardware key)

Last verified: 2026-05-17 20:19 UTC

@jonybur jonybur marked this pull request as ready for review May 17, 2026 18:52
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 17, 2026

Greptile Summary

This PR moves wallet onboarding terms into the chain selection flow. The main changes are:

  • Deletes the standalone TermsOfService screen and story.
  • Adds a Terms/Privacy checkbox to the Chains screen.
  • Starts the wallet dialog directly on the Chains screen.
  • Removes the vault simplified-terms feature flag and prop wiring.

Confidence Score: 2/5

This should be fixed before merging.

  • Terms can be recorded before the new checkbox is accepted.
  • Persistent reconnect can mark wallets connected without showing updated terms.
  • Staking-specific warnings were removed for all wallet connector consumers.
  • Simple-staking E2E wallet flows still target a deleted button.

Focus on Chains/index.tsx, useWalletConnectors.tsx, the removed TermsOfService flow, and the stale simple-staking selector.

Important Files Changed

Filename Overview
packages/babylon-wallet-connector/src/components/Chains/index.tsx Adds the new checkbox gate, but it is not tied to the existing acceptance hook or reconnect flow.
packages/babylon-wallet-connector/src/hooks/useWalletConnectors.tsx Existing connection lifecycle now conflicts with the new terms placement.
packages/babylon-wallet-connector/src/components/TermsOfService/index.tsx Removes the previous full terms flow and its staking-specific acknowledgements.

Comments Outside Diff (1)

  1. packages/babylon-wallet-connector/src/components/TermsOfService/index.tsx

    P1 Warnings were removed

    Deleting this screen removes the two non-simplified acknowledgements for inscription loss and supported hardware wallets, and the simplifiedTerms prop was removed from WalletProvider. That makes every consumer use the simplified one-checkbox flow, including flows that previously required users to acknowledge staking-specific risks before continuing.

Reviews (1): Last reviewed commit: "feat(vault): new onboarding for wallet" | Re-trigger Greptile

Comment thread packages/babylon-wallet-connector/src/components/Chains/index.tsx
@jonybur jonybur marked this pull request as draft May 18, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant