Skip to content

feat(vault): copy changes#1826

Merged
jrwbabylonlab merged 5 commits into
mainfrom
feat/copy-changes
Jun 3, 2026
Merged

feat(vault): copy changes#1826
jrwbabylonlab merged 5 commits into
mainfrom
feat/copy-changes

Conversation

@gbarkhatov
Copy link
Copy Markdown
Contributor

  • multiple copy changes

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

🔐 Commit Signature Verification

All 5 commit(s) passed verification

Commit Author Signature Key Type Key Check
2c1baa474461 Govard Barkhatov sk-ssh-ed25519
c43888e0b8b7 Govard Barkhatov sk-ssh-ed25519
8d6f35551c85 Govard Barkhatov sk-ssh-ed25519
be41d5e4a443 Govard Barkhatov sk-ssh-ed25519
20263080f95e Govard Barkhatov sk-ssh-ed25519

Summary

  • Commits verified: 5
  • Signature check: ✅ All passed
  • Key type enforcement: ✅ All sk-ssh-ed25519

Required key type: sk-ssh-ed25519 (FIDO2 hardware key)

Last verified: 2026-06-03 13:12 UTC

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Jun 3, 2026

Greptile Summary

This PR updates vault UI copy across deposit, withdrawal, and Aave loan surfaces. The main changes are:

  • Updates redemption, refund, split-vault, and payout status messages.
  • Renames the loan card metric from borrow rate to borrow ratio.
  • Changes loan rate wording from borrow rate to borrow APY.
  • Adds shared copy keys for borrow ratio and health factor labels.

Confidence Score: 4/5

This looks safe to merge after one user-facing status message is corrected.

  • The Aave label changes match the data passed into the components.

  • The APY change in the borrowed-assets hook is comment-only.

  • The refund success modal can show misleading wording after a successful Bitcoin refund broadcast.

  • services/vault/src/copy.ts refund success copy should be made past-tense and refund-specific.

Important Files Changed

Filename Overview
services/vault/src/copy.ts Centralized copy changes for deposit refund, redemption, pegout payout, split vaults, and loan labels.
services/vault/src/applications/aave/components/LoanCard/Borrow/BorrowDetailsCard/BorrowDetailsCard.tsx Moves borrow ratio and health factor labels to shared copy keys.
services/vault/src/applications/aave/hooks/useAaveBorrowedAssets.ts Updates documentation wording for borrow APY without changing runtime behavior.

Reviews (1): Last reviewed commit: "chore(pr): broadcast withdraw expired" | Re-trigger Greptile

Comment thread services/vault/src/copy.ts
@jrwbabylonlab jrwbabylonlab merged commit 8940d9c into main Jun 3, 2026
8 checks passed
@jrwbabylonlab jrwbabylonlab deleted the feat/copy-changes branch June 3, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants