Feature/enhance pattern matching

[eug-L]

Fixes #13

continuation of #11

• Removed composer autoloading and setup to download only for external modules
• Added collapsible area in form for pattern examples

[yorkshire-pudding]

Hi @eug-L
The convention in Backdrop is to create an issue (where all the discussion except code review comments happens) and then create a Pull Request that links to the issue by the phrase Fixes #xxx where xxx is the issue number. This creates a special link that closes the issue if and when the pull request is merged.

The correct way to link to libraries in Backdrop is through using the hook_autoload_info() function; this is used by backdrop_autoload(). Here is an example in another module I maintain.

https://github.com/backdrop-contrib/barcodes/blob/dc17924cb71fc63fe8c442456eeaaab7f5148de1/barcodes.module#L8-L95

One of the reasons for this is speed, allowing Backdrop to cache the class list. As this is called on every page, having it load this way is one of the things that keeps Backdrop fast.

If you can make that change, then I'll give this change a test and a more thorough review.

Am I right that Alvin Johnson So has left tawk.to? Should I close #11

[eug-L]

@yorkshire-pudding thanks for the comment

If you can make that change, then I'll give this change a test and a more thorough review.

Sure, I'll look into that

Am I right that Alvin Johnson So has left tawk.to? Should I close #11

Yes, please do

[eug-L]

hi @yorkshire-pudding I've implemented hook_autoload_info

let me know if anything else needs changes

[eug-L]

@yorkshire-pudding any updates on this?

[yorkshire-pudding]

@eug-L - apologies for the silence. I've been busy with work and also our Backdrop Live unconference. Please check the instructions in #12 (comment) and create an issue for this and update the top post with Fixes #xx where xx is the issue number. I have recently taken over the module GDPR Cookies and if I can build a "Vanisher" for the tawk.to cookies so the user has a choice, I may start to use this module again.

[eug-L]

@yorkshire-pudding no worries, thanks for the feedback. Created an issue & updated the top post.

For gdpr cookies we have a consent form on the chat widget that can be enabled from our dashboard, so a "vanisher" may not be needed

[yorkshire-pudding]

For gdpr cookies we have a consent form on the chat widget that can be enabled from our dashboard, so a "vanisher" may not be needed

Noted, but would be a better user experience if they can set cookie preferences in one place.

[eug-L]

@yorkshire-pudding We currently don’t have a way to accept the consent form programmatically. How do you plan to build the vanisher? Is there any way we can move this forward without it?

[eug-L]

@yorkshire-pudding follow up please