Backlog upgrade for redmine 4.0.5

- task directory deleted
- Add sidekiq dependancy to GemFile
- Change deprecated method *_filter by *_action, it is the equivalent since Rails5.2
- Change css z-index to prevent search menu to pass under backlog menu
- hash attribute to prevent internal error when drag and drop task
- Error Block Message in impediment

Author: Guillaume DUPE

Gemfile

@@ -1,4 +1,5 @@
-
+gem "sidekiq"
+gem 'erubis', '~> 2.7'
 gem "holidays", "~>1.0.3"
 gem "icalendar"
 gem "open-uri-cached"

app/controllers/rb_all_projects_controller.rb

@@ -1,7 +1,7 @@
 class RbAllProjectsController < ApplicationController
   unloadable
 
-  before_filter :authorize_global
+  before_action :authorize_global
 
   def statistics
     backlogs_projects = RbCommonHelper.find_backlogs_enabled_active_projects

app/controllers/rb_application_controller.rb

@@ -2,7 +2,7 @@
 class RbApplicationController < ApplicationController
   unloadable
 
-  before_filter :load_project, :authorize, :check_if_plugin_is_configured
+  before_action :load_project, :authorize, :check_if_plugin_is_configured
 
   #provide list of javascript_include_tags which must be rendered before common.js
   def rb_jquery_plugins

app/controllers/rb_calendars_controller.rb

@@ -5,7 +5,7 @@ class RbCalendarsController < RbApplicationController
 
   case Backlogs.platform
     when :redmine
-      before_filter :require_admin_or_api_request, :only => :ical
+      before_action :require_admin_or_api_request, :only => :ical
       accept_api_auth :ical
     when :chiliproject
       accept_key_auth :ical

app/controllers/rb_impediments_controller.rb

@@ -4,11 +4,13 @@ class RbImpedimentsController < RbApplicationController
   unloadable
 
   def create
-    @settings = Backlogs.settings
+    params.permit!
+    @settings = Backlogs.setting
     begin
       @impediment = RbTask.create_with_relationships(params, User.current.id, @project.id, true)
     rescue => e
-      render :text => e.message.blank? ? e.to_s : e.message, :status => 400
+      Rails.logger.error(e.message.blank? ? e.to_s : e.message)
+      render :partial => "backlogs/model_errors", :object => { "base" => e.message.blank? ? e.to_s : e.message }, :status => 400
       return
     end
 
@@ -22,8 +24,9 @@ def create
   end
 
   def update
+    params.permit!
     @impediment = RbTask.find_by_id(params[:id])
-    @settings = Backlogs.settings
+    @settings = Backlogs.setting
     begin
       result = @impediment.update_with_relationships(params)
     rescue => e

app/controllers/rb_project_settings_controller.rb

@@ -23,4 +23,7 @@ def project_settings
                 :tab => 'backlogs'
   end
 
+  def project_settings_params
+    params.require(:rb_project_settings).permit(:project_id);
+  end
 end

app/controllers/rb_releases_controller.rb

@@ -49,7 +49,7 @@ def edit
   def update
     except = ['id', 'project_id']
     attribs = params.select{|k,v| (!except.include? k) and (RbRelease.column_names.include? k) }
-    attribs = Hash[*attribs.flatten]
+    attribs = attribs.to_enum.to_h
     begin
       result  = @release.update_attributes attribs
     rescue => e

app/controllers/rb_server_variables_controller.rb

@@ -7,7 +7,7 @@ class RbServerVariablesController < RbApplicationController
 
   # for index there's no @project
   # (eliminates the need of RbAllProjectsController)
-  skip_before_filter :load_project, :authorize, :only => [:index]
+  skip_before_action :load_project, :authorize, :only => [:index]
 
   def index
     @context = params[:context]

app/controllers/rb_sprints_controller.rb

@@ -12,7 +12,7 @@ class RbSprintsController < RbApplicationController
 
   def create
     attribs = params.select{|k,v| k != 'id' and RbSprint.column_names.include? k }
-    attribs = Hash[*attribs.flatten]
+    attribs = attribs.to_enum.to_h
     @sprint = RbSprint.new(attribs)
 
     #share the sprint according to the global setting
@@ -43,7 +43,7 @@ def create
   def update
     except = ['id', 'project_id']
     attribs = params.select{|k,v| (!except.include? k) and (RbSprint.column_names.include? k) }
-    attribs = Hash[*attribs.flatten]
+    attribs = attribs.to_enum.to_h
     begin
       result  = @sprint.update_attributes attribs
     rescue => e

app/controllers/rb_stories_controller.rb

@@ -32,7 +32,8 @@ def create
     begin
       story = RbStory.create_and_position(params)
     rescue => e
-      render :text => e.message.blank? ? e.to_s : e.message, :status => 400
+      Rails.logger.error(e.message.blank? ? e.to_s : e.message)
+      render text: e.message.blank? ? e.to_s : e.message, status: 400
       return
     end
 
@@ -48,6 +49,7 @@ def update
     begin
       result = story.update_and_position!(params)
     rescue => e
+      Rails.logger.error(e.message.blank? ? e.to_s : e.message)
       render :text => e.message.blank? ? e.to_s : e.message, :status => 400
       return
     end