#31383 User can edit task priority on taskboard even when it is not v…#1133
Open
futaz wants to merge 1 commit into
Open
#31383 User can edit task priority on taskboard even when it is not v…#1133futaz wants to merge 1 commit into
futaz wants to merge 1 commit into
Conversation
Imran-imtiaz48
left a comment
There was a problem hiding this comment.
The selected line conditionally renders the "remaining_hours" field as an editable div, displaying the task's remaining hours only if the current user has the :update_remaining_hours permission for the project. This ensures that only authorized users can view and edit the remaining hours directly from the task view, enhancing security and role-based UI control. The approach is clear and consistent with permission-based rendering patterns, promoting maintainability and a better user experience by hiding editing options from those without the necessary privileges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…isible on it
Without this improvement, users can only edit task priority on taskboard when it is already differs from the default priority or when "Show task priority on taskboard" setting is enabled (so all tasks shows priority property even when it is the default one).
With this imporvement, users can edit priority even when it is the default one and the "Show task priority on taskboard" setting is disabled. After changing a default priority to something else, it will appear on the task' box of course and disappear when set back to the default.