fix(vscode): enable clipboard in webview iframe#968
Closed
rushelex wants to merge 1 commit into
Closed
Conversation
Copy and paste did not work inside the Plannotator VS Code panel because the embedded iframe lacked an `allow` attribute. Nested iframes in a VS Code webview are gated by Permissions Policy, so `navigator.clipboard` reads/writes and paste events were blocked. Grant clipboard-read and clipboard-write to the iframe. Fixes backnotprop#864 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing in favor of #970. This PR added The real fix routes the clipboard through the extension host |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #864.
In the VS Code extension, copying text from the Plannotator tab and pasting into a comment both silently fail.
Root cause
PanelManagerrenders the Plannotator app inside an<iframe>within the VS Code webview (apps/vscode-extension/src/panel-manager.ts). A VS Code webview is itself a sandboxed iframe, so a nested iframe is gated by Permissions Policy. The iframe had noallowattribute, which blocksnavigator.clipboardreads/writes andpasteevents in the embedded app.The app relies on
navigator.clipboard.writeTextfor every copy action (code blocks, tables, export, annotations, …) and onclipboardDatafor paste — all of these are blocked under the default permissions policy of a nested iframe.Fix
Grant clipboard access to the iframe:
Testing
panel-manager.test.tscase asserting the iframe HTML carriesallow="clipboard-read; clipboard-write".bun test src/panel-manager.test.ts→ 3 pass.bun run build:vscodesucceeds.🤖 Generated with Claude Code