Skip to content

fix(vscode): enable clipboard in webview iframe #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rushelex wants to merge 1 commit into from
Closed

fix(vscode): enable clipboard in webview iframe #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions apps/vscode-extension/src/panel-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,31 @@ describe("PanelManager", () => {
);
});

it("grants clipboard permission to the iframe", async () => {
let capturedHtml = "";
const spy = spyOn(vscode.window, "createWebviewPanel");
spy.mockImplementation((() => {
let disposeListener: (() => void) | null = null;
return {
webview: {
get html() { return capturedHtml; },
set html(v: string) { capturedHtml = v; },
},
reveal() {},
dispose() { disposeListener?.(); },
onDidDispose(listener: () => void) {
disposeListener = listener;
return { dispose() {} };
},
} as unknown as vscode.WebviewPanel;
}) as typeof vscode.window.createWebviewPanel);
spies.push(spy);

await manager.open("http://127.0.0.1:9999/review?id=42");

expect(capturedHtml).toContain('allow="clipboard-read; clipboard-write"');
});

it("uses asExternalUri resolved URL in iframe and CSP", async () => {
const envSpy = spyOn(vscode.env, "asExternalUri");
envSpy.mockImplementation(async (_uri: vscode.Uri) => {
Expand Down
2 changes: 1 addition & 1 deletion apps/vscode-extension/src/panel-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function getHtml(url: string, origin: string): string {
</style>
</head>
<body>
<iframe id="pn-frame" src="${url}"></iframe>
<iframe id="pn-frame" src="${url}" allow="clipboard-read; clipboard-write"></iframe>
${themeScript}
<script>
(function() {
Expand Down