Update dependency @patternfly/react-core to v6#7998
Update dependency @patternfly/react-core to v6#7998backstage-goalie[bot] wants to merge 1 commit into
Conversation
backstage-goalie
Bot
requested review from
a team,
dvail,
maknop and
sachaudh
as code owners
backstage-goalie
Bot
added
the
dependencies
Changed Packages
|
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
c11bad6 to
0c66c6a
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
0c66c6a to
67e7c41
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
67e7c41 to
5cf1cce
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
5cf1cce to
790a598
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
790a598 to
9e0bc35
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
9e0bc35 to
ec103b0
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
ec103b0 to
a09d7b1
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
a09d7b1 to
d040e59
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
d040e59 to
a9c0f8e
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
a9c0f8e to
fceabab
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
fceabab to
6ea1193
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
6ea1193 to
40ad51b
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
40ad51b to
29f766f
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
29f766f to
1da1620
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
1da1620 to
f3ccf7d
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
f3ccf7d to
6176ec4
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
6176ec4 to
80d9073
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
80d9073 to
9702c63
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
9702c63 to
8d4e669
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
8d4e669 to
cc0ae82
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
cc0ae82 to
55e9cf2
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
55e9cf2 to
e179f2a
Compare
backstage-goalie
Bot
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
e6c30af to
03c1d6f
Compare
backstage-service
force-pushed
the
renovate/patternfly-react-core-6.x
branch
from
03c1d6f to
7d41344
Compare
|
👋 Reminder: This Renovate major PR has been open for 21 days. Please review and merge if the changes look good. If no action is taken, this PR will be labeled |
There was a problem hiding this comment.
Pull request overview
Updates the ACS Backstage plugin workspace to use PatternFly React Core v6.
Changes:
- Bump
@patternfly/react-corefrom5.4.14to6.4.1in the plugin’spackage.json - Update
yarn.lockto reflect the new PatternFly v6 dependency graph - Add a changeset documenting the dependency update
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| workspaces/acs/plugins/acs/package.json | Updates the direct @patternfly/react-core dependency to v6.4.1 |
| workspaces/acs/yarn.lock | Locks the new @patternfly/react-core@6.4.1 resolution and related deps |
| workspaces/acs/.changeset/renovate-b6e8ecc.md | Records the dependency bump as a patch changeset |
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:45
@patternfly/react-corewas bumped to v6, but several other PatternFly packages are still pinned to v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology). The lockfile shows this keeps a full v5 PatternFly dependency subtree (including@patternfly/react-core@5.4.14) alongside v6, and any direct imports like@patternfly/react-styleswill resolve to the v5 package because it is listed here as a direct dependency. To avoid duplicated PatternFly majors and potential runtime/style mismatches, update the remaining PatternFly React packages to their v6-compatible versions (or remove unused ones) so the dependency graph converges on a single major version.
"@patternfly/react-charts": "7.4.9",
"@patternfly/react-component-groups": "^6.0.0",
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
"date-fns": "1.30.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-coreis now v6, but this package still pins several PatternFly packages to v5 (@patternfly/react-styles,@patternfly/react-icons,@patternfly/react-table, etc.). Since PF6 core depends on PF6 styles/tokens, this mixed-major setup can lead to inconsistent styling (e.g.,import '@patternfly/react-styles'will resolve to v5) and duplicate PF bundles. Align the direct@patternfly/*dependencies to the same major version (preferably PF6), or revert core back to PF5 until the rest are upgraded together.
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@patternfly/react-core": "6.4.1", | ||
| "@patternfly/react-icons": "5.4.2", | ||
| "@patternfly/react-styles": "5.4.1", | ||
| "@patternfly/react-table": "5.4.16", |
There was a problem hiding this comment.
@patternfly/react-core is now pinned to v6, but this package still pins other PatternFly packages to v5 (e.g. @patternfly/react-icons, @patternfly/react-styles, @patternfly/react-table). This leads to multiple major versions being installed (v5 + v6 in the lockfile), increasing bundle size and risking styling/runtime inconsistencies (e.g. import '@patternfly/react-styles' will resolve to v5 while core v6 depends on react-styles v6). Consider aligning the remaining PatternFly deps to the same major as react-core (upgrade to v6 where available) and/or removing v5-only deps that are no longer needed.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-corewas bumped to v6, but this package still pins other PatternFly packages to v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology). This forces mixed major versions in a single bundle and can cause styling/runtime mismatches (and also prevents Yarn from deduping to a single PF6 tree). Align these PatternFly dependencies to v6 (or remove the direct v5 pins if they’re not needed) so all PatternFly packages resolve to the same major.
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@backstage-community/plugin-acs': patch | |||
There was a problem hiding this comment.
This changeset marks the release as a patch, but the dependency update is a major bump (@patternfly/react-core v5 → v6). If this plugin is consumed externally, a major UI framework bump is likely to be at least a minor (and potentially major) release depending on whether it causes breaking changes for consumers (DOM/CSS changes, peer dep expectations, etc.). Consider increasing the changeset bump level or documenting why a patch is safe here.
| '@backstage-community/plugin-acs': patch | |
| '@backstage-community/plugin-acs': minor |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@backstage-community/plugin-acs': patch | |||
There was a problem hiding this comment.
The changeset marks this as a patch, but the PR upgrades @patternfly/react-core across a major version (PF5 → PF6), which is more likely to be breaking for consumers (UI/DOM/CSS changes, component API changes). Consider bumping the changeset to minor or major (per your release policy) to better reflect the risk/impact.
| '@backstage-community/plugin-acs': patch | |
| '@backstage-community/plugin-acs': minor |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@backstage-community/plugin-acs': patch | |||
There was a problem hiding this comment.
The changeset marks this as a patch, but the PR updates a direct dependency across a major version (@patternfly/react-core 5 → 6), which commonly introduces breaking UI/behavior changes even if your public API is unchanged. Recommendation (mandatory): reassess the changeset bump level—consider minor at least (or major if this can be consumer-breaking), based on how this plugin is consumed/released and whether the UI/CSS/behavior changes are observable by downstream users.
| '@backstage-community/plugin-acs': patch | |
| '@backstage-community/plugin-acs': minor |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-corewas bumped to v6, but this package still pins several other PatternFly React packages to v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology). With this combination, the lockfile now contains both PF5 and PF6 dependency graphs (e.g.,@patternfly/react-table@5.4.16pulls@patternfly/react-core@^5.4.14while the plugin pulls@patternfly/react-core@6.4.1), which risks inconsistent styling/behavior and increases bundle size. Please upgrade the remaining PatternFly React dependencies to compatible v6 versions (or revertreact-coreto v5 so all PF packages stay on the same major).
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-corewas bumped to v6, but this package still pins other PatternFly packages to v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology). This results in mixed PatternFly major versions (and duplicated transitive deps), and@patternfly/react-stylesin particular is imported insrcso it should match the PF6 core version. Align all@patternfly/react-*deps to the same major (preferably v6) or remove the unused PF5 packages so the plugin doesn't pull both PF5 and PF6 at once.
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-coreis bumped to v6, but other PatternFly React packages here remain on v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology). This causes Yarn to install both PF5 and PF6 dependency trees (e.g., v5react-table/react-topologypull@patternfly/react-core@^5.xwhilereact-core@6.xpullsreact-icons/react-stylesv6), which can lead to duplicated base CSS/tokens and inconsistent styling/behavior at runtime. Prefer upgrading the rest of the PatternFly packages to compatible v6 versions (or removing unused PF5 packages / keepingreact-coreon v5) so only one major PatternFly stack is present.
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-corewas bumped to v6, but several other PatternFly packages are still pinned to v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology). This results in multiple major versions of PatternFly packages (and even@patternfly/react-core) being installed, which can cause duplicated CSS/JS, larger bundles, and potential runtime/style incompatibilities. Please align the PatternFly React dependency set to a single major version (preferably bump the remaining@patternfly/*deps to their v6 equivalents, or revertreact-coreto v5 until the rest can be upgraded).
"@patternfly/react-charts": "7.4.9",
"@patternfly/react-component-groups": "^6.0.0",
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-coreis being upgraded to v6, but the package still pins other PatternFly packages (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology) to v5. This results in both PF5 and PF6 copies being installed (e.g., yarn.lock contains@patternfly/react-styles5.4.1 and 6.4.0), which can cause styling/behavior mismatches and larger bundles. Align the PatternFly dependencies to the same major (preferably bump the remaining direct@patternfly/react-*deps to v6, or remove unused direct deps and rely on v6 transitive deps).
"@patternfly/react-charts": "7.4.9",
"@patternfly/react-component-groups": "^6.0.0",
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-corewas bumped to v6, but several closely-coupled PatternFly packages are still pinned to v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology). This currently forces Yarn to install both PF5 and PF6 (e.g.,@patternfly/react-table@5depends on@patternfly/react-core@^5.4.14), which can lead to duplicated bundles and runtime/style incompatibilities. Consider aligning the PatternFly package set to a single major version (upgrade the remaining PF packages to their v6-compatible releases, or keep@patternfly/react-coreon v5 until the rest can be upgraded/removed).
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-corewas bumped to v6, but this package still pins other PatternFly React packages to v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology). This results in multiple major versions of PatternFly being installed and used together, and can cause styling/runtime incompatibilities (and larger bundles). Consider aligning the PatternFly dependency set to the same major version (preferably v6), or reverting@patternfly/react-coreuntil the remaining PatternFly deps can be upgraded/removed.
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@backstage-community/plugin-acs': patch | |||
There was a problem hiding this comment.
This changeset marks the release as a patch, but the change upgrades a direct dependency across a major version boundary (@patternfly/react-core 5.x → 6.x), which is likely to be breaking for consumers (especially around CSS/styling). Consider using a minor/major bump (for 0.x packages, typically minor) to reflect the potential impact.
| '@backstage-community/plugin-acs': patch | |
| '@backstage-community/plugin-acs': major |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-coreis bumped to v6, but this package still pins several PatternFly packages to v5 (notably@patternfly/react-styles, which is also imported in the code). This will install both PF5 and PF6 packages (as seen inyarn.lock) and can lead to styling/runtime mismatches. Align the@patternfly/*deps to the same major (preferably v6.x for icons/styles/table/topology) or drop the explicit v5 deps if they’re no longer used so Yarn resolves a single major line.
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-corewas bumped to v6, but this package still pins several PatternFly packages at v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology, and@patternfly/react-charts). The lockfile shows this results in both@patternfly/react-core@5.4.14and@patternfly/react-core@6.4.1being installed (e.g.,@patternfly/react-table@5.4.16depends on@patternfly/react-core@^5.4.14), which can cause duplicated bundles and inconsistent styling/runtime behavior. Consider upgrading the remaining PatternFly deps to compatible v6 versions (or keeping@patternfly/react-coreon v5 until the rest can be upgraded) so all PatternFly packages share the same major version.
"@patternfly/react-charts": "7.4.9",
"@patternfly/react-component-groups": "^6.0.0",
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@backstage-community/plugin-acs': patch | |||
There was a problem hiding this comment.
This changeset marks the release as a patch, but it upgrades a major UI dependency (@patternfly/react-core 5 → 6), which can be a breaking change for consumers (e.g., requiring PF6 across the app or causing duplicate PF versions). Consider bumping this changeset to minor or major to better reflect the potential consumer impact.
| '@backstage-community/plugin-acs': patch | |
| '@backstage-community/plugin-acs': minor |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@backstage-community/plugin-acs': patch | |||
There was a problem hiding this comment.
The changeset marks this as a patch, but the PR upgrades a major UI dependency (@patternfly/react-core 5 → 6). If this package is published for external consumers, consider whether this should be a minor or major bump per your semver policy (major dependency upgrades can change UI behavior/styling and may introduce breaking changes).
| '@backstage-community/plugin-acs': patch | |
| '@backstage-community/plugin-acs': minor |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@backstage-community/plugin-acs': patch | |||
There was a problem hiding this comment.
The changeset marks this as a patch, but this PR upgrades a major UI dependency (@patternfly/react-core 5 → 6), which commonly includes breaking changes and can affect consumers of the plugin (rendering/DOM structure/classnames, component props used internally, etc.). Consider using at least a minor (or major if your package’s public surface/expected behavior changes) to better reflect upgrade impact in semver.
| '@backstage-community/plugin-acs': patch | |
| '@backstage-community/plugin-acs': minor |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-corewas bumped to v6, but this package still pins several PatternFly packages to v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology, and@patternfly/react-charts). This results in multiple PatternFly majors being installed (lockfile shows v6.4.x and v5.4.x), which commonly leads to duplicated CSS/tokens and inconsistent component styling at runtime.
Suggested fix: align the PatternFly dependencies to the same major (preferably v6 where available), or remove the v5 direct deps if they are not actually imported/needed by this plugin.
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '@backstage-community/plugin-acs': patch | ||
| --- | ||
|
|
||
| Updated dependency `@patternfly/react-core` to `6.4.1`. |
There was a problem hiding this comment.
This changeset marks the release as a patch, but it upgrades @patternfly/react-core across a major version (v5 → v6). If consumers of this plugin can be affected by PatternFly major-version changes (styling, transitive deps, duplication with app-level PatternFly), consider using a minor/major bump or explicitly noting potential breaking impact in the changeset text.
| '@backstage-community/plugin-acs': patch | |
| --- | |
| Updated dependency `@patternfly/react-core` to `6.4.1`. | |
| '@backstage-community/plugin-acs': minor | |
| --- | |
| Updated dependency `@patternfly/react-core` from v5 to `6.4.1` (PatternFly v6). | |
| This may affect consumers through PatternFly major-version changes such as styling, | |
| transitive dependencies, or duplication with app-level PatternFly packages. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-corewas bumped to v6, but the plugin still pins several PatternFly packages at v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology, and@patternfly/react-charts). This creates a mixed PF5/PF6 dependency set (and likely multiple copies of PatternFly packages/tokens), which can cause styling/runtime incompatibilities and larger bundles. Consider upgrading the remaining PatternFly packages to compatible v6 versions (or revertingreact-coreto v5 until a full PF6 migration is done).
"@patternfly/react-charts": "7.4.9",
"@patternfly/react-component-groups": "^6.0.0",
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
workspaces/acs/plugins/acs/package.json:44
@patternfly/react-coreis bumped to v6, but related PatternFly packages are still pinned to v5 (@patternfly/react-icons,@patternfly/react-styles,@patternfly/react-table,@patternfly/react-topology). This results in multiple major versions being installed (see yarn.lock entries for both 5.x and 6.x), which can lead to duplicated bundles and potentially incompatible styling/tokens if any PF components/icons are used together. Consider aligning the other PatternFly deps to the PF6 line where available (or removing unused PF5 deps) so the dependency graph resolves to a single major version set.
"@patternfly/react-core": "6.4.1",
"@patternfly/react-icons": "5.4.2",
"@patternfly/react-styles": "5.4.1",
"@patternfly/react-table": "5.4.16",
"@patternfly/react-topology": "5.4.1",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Renovate Bot <bot@renovateapp.com>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
5.4.14→6.4.3Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
patternfly/patternfly-react (@patternfly/react-core)
v6.4.3Compare Source
v6.4.2Compare Source
v6.4.1Compare Source
Updates Include:
- fix(Wizard): Fix crash in nav when first sub-step is hidden
- fix(CodeEditor): prevent focus loss (#12211)
- chore: Updated with snyk react router, and lodash requests
v6.4.0Compare Source
What's Changed
PopperPropsin derivative component types by @logonoff in #11934onSelectby @logonoff in #11935New Contributors
Full Changelog: patternfly/patternfly-react@v6.3.1...v6.4.0
v6.3.1Compare Source
fix(textarea): fix height logic for autoresize textarea (#11922)
fix(table): add pf-m-small to expandable toggle on small tables (#11947)
fix(Page): pass sidebar state to button for isHamburger (#11951)
v6.3.0Compare Source
What's Changed
New Contributors
Full Changelog: patternfly/patternfly-react@v6.2.2...v6.3.0
v6.2.3Compare Source
v6.2.2Compare Source
Full Changelog: patternfly/patternfly-react@v6.2.0...v6.2.2
v6.2.1Compare Source
v6.2.0Compare Source
What's Changed
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.