Update dependency nodemailer to v8 [SECURITY]#8341
Update dependency nodemailer to v8 [SECURITY]#8341backstage-goalie[bot] wants to merge 1 commit into
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
f38e648 to
7a41674
Compare
7a41674 to
dd5f07a
Compare
dd5f07a to
3e5f001
Compare
3e5f001 to
699ff5e
Compare
699ff5e to
b165b71
Compare
b165b71 to
331edc5
Compare
331edc5 to
f8254c8
Compare
f8254c8 to
63438be
Compare
63438be to
bf0923c
Compare
bf0923c to
720b1c4
Compare
720b1c4 to
202d242
Compare
202d242 to
cc280b1
Compare
cc280b1 to
9f4d755
Compare
9f4d755 to
57337af
Compare
57337af to
544d3cc
Compare
544d3cc to
2f2b11b
Compare
2f2b11b to
48ad5bc
Compare
48ad5bc to
b37b639
Compare
b37b639 to
e8173fc
Compare
e8173fc to
89c2bf0
Compare
89c2bf0 to
6c6b13e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '@backstage-community/plugin-feedback-backend': patch | ||
| --- | ||
|
|
||
| Updated dependency `nodemailer` to `^8.0.0`. |
There was a problem hiding this comment.
This changeset says nodemailer was updated to ^8.0.0, but the lockfile resolves nodemailer to 8.0.5 and the security fixes referenced in the PR are in 8.0.5. Please update the changeset text (and ideally the dependency range) to reflect the actual minimum safe version.
| Updated dependency `nodemailer` to `^8.0.0`. | |
| Updated dependency `nodemailer` to `^8.0.5`. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '@backstage-community/plugin-feedback-backend': patch | ||
| --- | ||
|
|
||
| Updated dependency `nodemailer` to `^8.0.0`. |
There was a problem hiding this comment.
This changeset says Nodemailer was updated to ^8.0.0, but the lockfile resolves to 8.0.5 (and the security advisories in the PR description reference fixes in 8.0.4/8.0.5). If you raise the dependency floor to the patched version, please update this changeset text to match.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '@backstage-community/plugin-feedback-backend': patch | ||
| --- | ||
|
|
||
| Updated dependency `nodemailer` to `^8.0.0`. |
There was a problem hiding this comment.
If you adjust the Nodemailer version range to a patched minimum (e.g. ^8.0.5+), please also update this changeset text to match the final dependency spec so the release note remains accurate.
| Updated dependency `nodemailer` to `^8.0.0`. | |
| Updated dependency `nodemailer` to `^8.0.5`. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '@backstage-community/plugin-feedback-backend': patch | ||
| --- | ||
|
|
||
| Updated dependency `nodemailer` to `^8.0.0`. |
There was a problem hiding this comment.
This changeset says nodemailer was updated to ^8.0.0, but that range still includes versions mentioned in the PR description as vulnerable (fixed in 8.0.5+). If you raise the minimum required version in package.json, please also update this changeset text to match the secured minimum version.
| Updated dependency `nodemailer` to `^8.0.0`. | |
| Updated dependency `nodemailer` to `^8.0.5`. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '@backstage-community/plugin-feedback-backend': patch | ||
| --- | ||
|
|
||
| Updated dependency `nodemailer` to `^8.0.0`. |
There was a problem hiding this comment.
This changeset text says Nodemailer was updated to ^8.0.0, but the security advisories described in the PR are fixed starting in later 8.0.x releases. If you bump the dependency minimum to a patched release, update this changeset message accordingly to avoid documenting an unsafe minimum version.
| Updated dependency `nodemailer` to `^8.0.0`. | |
| Updated dependency `nodemailer` to `^8.0.2`. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Signed-off-by: Renovate Bot <bot@renovateapp.com>
This PR contains the following updates:
^7.0.7→^8.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Nodemailer has SMTP command injection due to unsanitized
envelope.sizeparameterGHSA-c7w3-x93f-qmm8
More information
Details
Summary
When a custom
envelopeobject is passed tosendMail()with asizeproperty containing CRLF characters (\r\n), the value is concatenated directly into the SMTPMAIL FROMcommand without sanitization. This allows injection of arbitrary SMTP commands, includingRCPT TO— silently adding attacker-controlled recipients to outgoing emails.Details
In
lib/smtp-connection/index.js(lines 1161-1162), theenvelope.sizevalue is concatenated into the SMTPMAIL FROMcommand without any CRLF sanitization:This contrasts with other envelope parameters in the same function that ARE properly sanitized:
from,to): validated for[\r\n<>]at lines 1107-1127dsn.ret,dsn.envid,dsn.orcpt): encoded viaencodeXText()at lines 1167-1183The
sizeproperty reaches this code path throughMimeNode.setEnvelope()inlib/mime-node/index.js(lines 854-858), which copies all non-standard envelope properties verbatim:Since
_sendCommand()writes the command string followed by\r\nto the raw TCP socket, a CRLF in thesizevalue terminates theMAIL FROMcommand and starts a new SMTP command.Note: by default, Nodemailer constructs the envelope automatically from the message's
from/tofields and does not includesize. This vulnerability requires the application to explicitly pass a customenvelopeobject with asizeproperty tosendMail().While this limits the attack surface, applications that expose envelope configuration to users are affected.
PoC
ave the following as
poc.jsand run withnode poc.js:Expected output:
The
RCPT TO:<attacker@evil.com>line is injected by the CRLF in thesizefield, silently adding an extra recipient to the email.Impact
This is an SMTP command injection vulnerability. An attacker who can influence the
envelope.sizeproperty in asendMail()call can:RCPT TOcommands, receiving copies of all emails sent through the affected transportRSET, additionalMAIL FROMto send entirely separate emails through the server)The severity is mitigated by the fact that the
envelopeobject must be explicitly provided by the application. Nodemailer's default envelope construction from message headers does not includesize. Applications that pass through user-controlled data to the envelope options (e.g., via API parameters, admin panels, or template configurations) are vulnerable.Affected versions: at least v8.0.3 (current); likely all versions where
envelope.sizeis supported.Severity
CVSS:4.0/AV:N/AC:L/AT:P/PR:L/UI:N/VC:N/VI:L/VA:N/SC:N/SI:N/SA:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Nodemailer Vulnerable to SMTP Command Injection via CRLF in Transport name Option (EHLO/HELO)
GHSA-vvjj-xcjg-gr5g
More information
Details
Summary
Nodemailer versions up to and including 8.0.4 are vulnerable to SMTP command injection via CRLF sequences in the transport
nameconfiguration option. Thenamevalue is used directly in the EHLO/HELO SMTP command without any sanitization for carriage return and line feed characters (\r\n). An attacker who can influence this option can inject arbitrary SMTP commands, enabling unauthorized email sending, email spoofing, and phishing attacks.Details
The vulnerability exists in
lib/smtp-connection/index.js. When establishing an SMTP connection, thenameoption is concatenated directly into the EHLO command:The
_sendCommandmethod writes the string directly to the socket followed by\r\n(line 1082):If the
nameoption contains\r\nsequences, each injected line is interpreted by the SMTP server as a separate command. Unlike theenvelope.fromandenvelope.tofields which are validated for\r\n(line 1107-1119), and unlikeenvelope.sizewhich was recently fixed (GHSA-c7w3-x93f-qmm8) by casting to a number, thenameparameter receives no CRLF sanitization whatsoever.This is distinct from the previously reported GHSA-c7w3-x93f-qmm8 (envelope.size injection) as it affects a different parameter (
namevssize), uses a different injection point (EHLO command vs MAIL FROM command), and occurs at connection initialization rather than during message sending.The
nameoption is also used in HELO (line 1384) and LHLO (line 1333) commands with the same lack of sanitization.PoC
Running this PoC shows the SMTP server receives the injected MAIL FROM, RCPT TO, DATA, and phishing email content as separate SMTP commands before the legitimate email is sent.
Impact
Who is affected: Applications that allow users or external input to configure the
nameSMTP transport option. This includes:What can an attacker do:
The injection occurs at the EHLO stage (before authentication in most SMTP flows), making it particularly dangerous as the injected commands may be processed with the server's trust context.
Recommended fix: Sanitize the
nameoption by stripping or rejecting CRLF sequences, similar to howenvelope.fromandenvelope.toare already validated on lines 1107-1119 oflib/smtp-connection/index.js. For example:Severity
CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:U/C:N/I:H/A:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Release Notes
nodemailer/nodemailer (nodemailer)
v8.0.5Compare Source
Bug Fixes
v8.0.4Compare Source
Bug Fixes
v8.0.3Compare Source
Bug Fixes
v8.0.2Compare Source
Bug Fixes
v8.0.1Compare Source
Bug Fixes
v8.0.0Compare Source
⚠ BREAKING CHANGES
Bug Fixes
v7.0.13Compare Source
Bug Fixes
v7.0.12Compare Source
Bug Fixes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.