Skip to content

Update dependency jest-when to v4 #8563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
backstage-goalie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency jest-when to v4 #8563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions workspaces/kafka/.changeset/renovate-5764c28.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@backstage-community/plugin-kafka-backend': patch
'@backstage-community/plugin-kafka': patch
---

Updated dependency `jest-when` to `^4.0.0`.
2 changes: 1 addition & 1 deletion workspaces/kafka/plugins/kafka-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@types/jest-when": "^3.5.0",
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest-when v4 ships its own TypeScript types, but this package still includes @types/jest-when (which targets the pre-v4 typings). Keeping both can lead to stale/incorrect type resolution in some TS setups and is generally redundant—consider removing @types/jest-when from devDependencies now that jest-when provides types.

Suggested change
"@types/jest-when": "^3.5.0",

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that jest-when v4 is authored in TypeScript and ships its own typings, @types/jest-when is typically redundant. Consider removing @types/jest-when from devDependencies to avoid maintaining an extra (and potentially stale) type package.

Suggested change
"@types/jest-when": "^3.5.0",

Copilot uses AI. Check for mistakes.
"@types/lodash": "^4.14.151",
"@types/supertest": "^7.0.0",
"jest-when": "^3.1.0",
"jest-when": "^4.0.0",
Comment on lines 72 to +75
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that jest-when is on v4 (authored in TypeScript and typically ships its own .d.ts), keeping @types/jest-when (v3.x) in devDependencies is likely redundant and can cause confusion or type conflicts. Consider removing @types/jest-when and relying on the bundled types from jest-when v4 (updating the lockfile accordingly).

Copilot uses AI. Check for mistakes.
"supertest": "^7.0.0"
Comment on lines 72 to 76
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest-when v4 is authored in TypeScript and ships its own typings; keeping @types/jest-when (which targets the older v3 API/types) can cause TypeScript to pick up incompatible/duplicate declarations. Remove @types/jest-when from devDependencies (and regenerate the lockfile) so the project uses the bundled types from jest-when.

Copilot uses AI. Check for mistakes.
},
"configSchema": "config.d.ts"
Expand Down
2 changes: 1 addition & 1 deletion workspaces/kafka/plugins/kafka/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"@testing-library/jest-dom": "^6.0.0",
"@testing-library/react": "^15.0.0",
"@types/react-dom": "^18.2.19",
"jest-when": "^3.1.0",
"jest-when": "^4.0.0",
"react": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react-router-dom": "6.0.0-beta.0 || ^6.3.0"
Expand Down
14 changes: 7 additions & 7 deletions workspaces/kafka/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1656,7 +1656,7 @@ __metadata:
"@types/supertest": "npm:^7.0.0"
express: "npm:^4.17.1"
express-promise-router: "npm:^4.1.0"
jest-when: "npm:^3.1.0"
jest-when: "npm:^4.0.0"
kafkajs: "npm:^2.0.0"
lodash: "npm:^4.17.21"
supertest: "npm:^7.0.0"
Expand Down Expand Up @@ -1686,7 +1686,7 @@ __metadata:
"@testing-library/react": "npm:^15.0.0"
"@types/react": "npm:^16.13.1 || ^17.0.0 || ^18.0.0"
"@types/react-dom": "npm:^18.2.19"
jest-when: "npm:^3.1.0"
jest-when: "npm:^4.0.0"
react: "npm:^16.13.1 || ^17.0.0 || ^18.0.0"
react-dom: "npm:^16.13.1 || ^17.0.0 || ^18.0.0"
react-router-dom: "npm:6.0.0-beta.0 || ^6.3.0"
Expand Down Expand Up @@ -16689,12 +16689,12 @@ __metadata:
languageName: node
linkType: hard

"jest-when@npm:^3.1.0":
version: 3.6.0
resolution: "jest-when@npm:3.6.0"
"jest-when@npm:^4.0.0":
version: 4.0.3
resolution: "jest-when@npm:4.0.3"
peerDependencies:
jest: ">= 25"
checksum: 10/0cb92738ccfa5711a685107f4437f18aefbe3cda120c912a9d49b612eeef03a910481ab40fe753fd42c4e617ffbb3d84c6bd66a76d963dac7f1ad9e9e5059359
jest: ">= 27"
checksum: 10/71b35080b6d9cadf0828da440e3d3799d50aaa806ef8a1ad36fe89be5a93b2340c987b12a253cab66f7937a515252a5e3cbd839e88785f9d6d926452377c08eb
languageName: node
linkType: hard

Expand Down
Loading