Update dependency uuid to v14 [SECURITY] - abandoned#8794
Update dependency uuid to v14 [SECURITY] - abandoned#8794backstage-goalie[bot] wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@mui/styles": "^5.16.6", | ||
| "react-use": "^17.2.4", | ||
| "uuid": "^11.1.0" | ||
| "uuid": "^14.0.0" |
There was a problem hiding this comment.
uuid@^14 lists TypeScript >= 5.4.3 as the minimum supported version, but this workspace is pinned to typescript@~5.3.0 (resolves to 5.3.3 in this workspace yarn.lock). This can cause type-check/build failures; please bump the workspace TypeScript version (or otherwise ensure tsc runs on >=5.4.3) alongside this uuid upgrade.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "knex": "^3.1.0", | ||
| "ollama": "^0.6.0", | ||
| "uuid": "^11.0.0" | ||
| "uuid": "^14.0.0" |
There was a problem hiding this comment.
Upgrading to uuid@^14 raises the runtime requirement to Node.js 20+ (uuid now expects a global crypto). The plugin docs currently state Node.js 18+; please either update the stated support/docs (and/or add an engines.node constraint) or avoid this upgrade if Node 18 support is still required.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
workspaces/tech-insights/plugins/tech-insights-backend/package.json:1
uuid@14includes breaking runtime/platform expectations (notably Node support changes and reliance on a globally-definedcrypto, per upstream release notes). Since this PR updates the dependency range, it should also update the package's supported-runtime signaling (e.g.,engines.nodeand/or CI node matrix) to ensure consumers on unsupported Node versions fail fast during install/CI rather than at runtime. Apply the same adjustment consistently to the other workspaces bumped to^14.0.0.
workspaces/tech-insights/.changeset/renovate-3deaa6f.md:1- The Changeset marks this as a
patch, but upgrading touuid@14can imply a breaking change for consumers if it effectively raises the minimum supported Node/runtime requirements (or changes module system expectations). If this package previously supported older Node versions, consider bumping the Changeset tomajor(or at leastminor) to reflect the compatibility impact; alternatively, explicitly constrainengines.nodeso the change is clearly communicated and enforced.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "react-use": "^17.2.4", | ||
| "uuid": "^11.1.0" | ||
| "uuid": "^14.0.0" | ||
| }, |
There was a problem hiding this comment.
uuid@14.0.0 raises the uuid project’s minimum supported TypeScript version to 5.4.3 (per its v14 release notes). This workspace currently pins TypeScript to ~5.3.0 (workspaces/agent-forge/package.json), which can lead to type-check/build failures; please bump the workspace TypeScript version to >=5.4.3 (or align with the repo’s newer TypeScript versions) before landing this update.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Renovate Bot <bot@renovateapp.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: gaelgoth <gothuey.gael@gmail.com>
|
I removed deprecated |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
|
👋 Reminder: This Renovate major PR has been open for 21 days. Please review and merge if the changes look good. If no action is taken, this PR will be labeled |
This PR contains the following updates:
^9.0.0→^14.0.0^13.0.0→^14.0.0^11.0.0→^14.0.0^11.1.0→^14.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
uuid: Missing buffer bounds check in v3/v5/v6 when buf is provided
GHSA-w5hq-g745-h8pq
More information
Details
Summary
v3,v5, andv6accept external output buffers but do not reject out-of-range writes (smallbufor largeoffset).By contrast,
v4,v1, andv7explicitly throwRangeErroron invalid bounds.This inconsistency allows silent partial writes into caller-provided buffers.
Affected code
src/v35.ts(v3/v5path) writesbuf[offset + i]without bounds validation.src/v6.tswritesbuf[offset + i]without bounds validation.Reproducible PoC
Observed:
v4 THREW RangeErrorv5 NO_THROWv6 NO_THROWExample partial overwrite evidence captured during audit:
Security impact
Suggested fix
Add the same guard used by
v4/v1/v7:Apply to:
src/v35.ts(coversv3andv5)src/v6.tsSeverity
CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:L/VA:N/SC:N/SI:N/SA:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Release Notes
uuidjs/uuid (uuid)
v14.0.0Compare Source
Security
v3(),v5(), andv6()did not validate that writes would remain within the bounds of a caller-supplied buffer, allowing out-of-bounds writes when an invalidoffsetwas provided. ARangeErroris now thrown ifoffset < 0oroffset + 16 > buf.length.⚠ BREAKING CHANGES
cryptois now expected to be globally defined (requires node@20+) (#935)v13.0.0Compare Source
⚠ BREAKING CHANGES
Bug Fixes
v12.0.0Compare Source
⚠ BREAKING CHANGES
Features
Bug Fixes
v11.1.0Compare Source
Features
Uint8Arraysubtypes forbufferoption (#865) (a5231e7)v11.0.5Compare Source
Bug Fixes
v11.0.4Compare Source
Bug Fixes
v1(),v4(), andv7()(#845) (e0ee900)v11.0.3Compare Source
Bug Fixes
v11.0.2Compare Source
Bug Fixes
v11.0.1Compare Source
Bug Fixes
v11.0.0Compare Source
⚠ BREAKING CHANGES
Features
Bug Fixes
v10.0.0Compare Source
⚠ BREAKING CHANGES
Features
Bug Fixes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate.