Sync to GitHub

Author: CI

lib/bacnet/protocol/object_types/device.ex

@@ -252,19 +252,36 @@ defmodule BACnet.Protocol.ObjectTypes.Device do
   @external_resource BACstack.MixProject.get_vendor_ids_csv_file()
   @vendor_ids BACstack.MixProject.get_vendor_ids()
 
+  # Dialyzer is so hecking stupid - go love yourself with your stupid opaqueness contracts
+  @dialyzer {:nowarn_function, get_vendor_ids: 0, get_vendor_ids_arr: 0, map_vendor_to_name: 1}
+
+  @spec get_vendor_ids_arr() :: :array.array(String.t())
+  defp get_vendor_ids_arr(), do: @vendor_ids
+
   @doc """
   Get the list of known vendor IDs to vendor names.
+
+  > #### Implementation Detail {: .info}
+  > Internally the vendor IDs mapping is represented as an erlang array
+  > and will be converted to a map. If you use this map multiple times in a row,
+  > consider storing it in a variable as the conversion can be computational heavy.
   """
   @spec get_vendor_ids() :: %{optional(non_neg_integer()) => String.t()}
   def get_vendor_ids() do
-    @vendor_ids
+    get_vendor_ids_arr()
+    |> :array.sparse_to_orddict()
+    |> Map.new()
   end
 
-  @spec map_vendor_to_name(non_neg_integer) :: String.t()
-  defp map_vendor_to_name(id) do
-    Map.get(@vendor_ids, id, "")
+  @spec map_vendor_to_name(non_neg_integer()) :: String.t()
+  defp map_vendor_to_name(id)
+
+  defp map_vendor_to_name(id) when is_integer(id) and id >= 0 do
+    :array.get(id, get_vendor_ids_arr())
   end
 
+  defp map_vendor_to_name(_id), do: ""
+
   @spec inhibit_object_check(t()) :: {:ok, t()}
   defp inhibit_object_check(obj) do
     # Only patch vendor name if empty

mix.exs

@@ -18,6 +18,8 @@ defmodule BACstack.MixProject do
       deps: deps(),
       package: package(),
       dialyzer: [
+        # Flags could be ["-Wno_opaque"]
+        flags: [],
         ignore_warnings: "dialyzer.ignore-warnings.exs",
         plt_add_apps: [:mix]
       ],
@@ -538,7 +540,8 @@ defmodule BACstack.MixProject do
     Path.join([__DIR__, "priv", "vendor_ids.csv"])
   end
 
-  @spec get_vendor_ids() :: %{optional(non_neg_integer()) => String.t()}
+  # Returns an :array.array(String.t()), but dialyzer doesn't like that
+  @spec get_vendor_ids() :: term()
   def get_vendor_ids() do
     if not File.exists?(get_vendor_ids_csv_file()) do
       Mix.Task.run("bacnet.dl.vendorids")
@@ -547,18 +550,19 @@ defmodule BACstack.MixProject do
     parse_vendor_ids_csv()
   end
 
-  @spec parse_vendor_ids_csv() :: %{optional(non_neg_integer()) => String.t()}
+  # Returns an :array.array(String.t()), but dialyzer doesn't like that
+  @spec parse_vendor_ids_csv() :: term()
   def parse_vendor_ids_csv() do
     get_vendor_ids_csv_file()
-    |> File.read!()
-    |> String.split("\n")
+    |> File.stream!()
     |> Stream.flat_map(fn line ->
       case String.split(line, ";") do
-        [id, name] -> [{String.to_integer(id), name}]
+        [id, name] -> [{String.to_integer(id), String.trim(name)}]
         _else -> []
       end
     end)
-    |> Map.new()
+    |> Enum.sort_by(&elem(&1, 0))
+    |> :array.from_orddict("")
   end
 
   #### Download BACnet Vendor IDs list from the BACnet website END ####