Sync to GitHub

Author: CI

lib/bacnet/stack/transport/mstp_transport.ex

@@ -1271,6 +1271,19 @@ if Code.ensure_loaded?(Circuits.UART) do
     end
 
     @doc false
+    def handle_info({:serial_crash, reason}, %State{} = state) do
+      # This message is either sent by ReceiveFSM or when writing UART fails
+      Logger.error(fn ->
+        "BacMstpTransport: UART error encountered and shutting down, error: " <> inspect(reason)
+      end)
+
+      # Stop everything
+      ReceiveFSM.close(state.receive_fsm)
+      UART.close(state.uart_pid)
+
+      {:stop, {:uart_error, reason}, state}
+    end
+
     def handle_info(:wakeup_use_token, %State{} = state) do
       {:noreply, state, {:continue, :use_token}}
     end
@@ -2646,6 +2659,12 @@ if Code.ensure_loaded?(Circuits.UART) do
               inspect(reason)
           end)
 
+          # Common errors are :badf and :eio
+          # They are bad enough we need to stop (serial port is gone, dead, etc.)
+          if reason not in [:eagain, :eintr] do
+            send(self(), {:serial_crash, reason})
+          end
+
           {:error, state}
       end
     end

lib/bacnet/stack/transport/mstp_transport/receive_fsm.ex

@@ -138,6 +138,11 @@ if Code.ensure_loaded?(Circuits.UART) do
           inspect(reason)
       end)
 
+      if reason not in [:eagain, :eintr] do
+        # Notify Transport Master and it will shut everything down
+        send(data.transport_master, {:serial_crash, reason})
+      end
+
       {:keep_state, %{data | event_count: data.event_count + 1}}
     end