Skip to content

Feature/bacnet zigbee link layer handler#70

Merged
luiz-santana18 merged 7 commits into
defaultfrom
feature/bacnet-zigbee-link-layer-handler
May 12, 2026
Merged

Feature/bacnet zigbee link layer handler#70
luiz-santana18 merged 7 commits into
defaultfrom
feature/bacnet-zigbee-link-layer-handler

Conversation

@luiz-santana18

Copy link
Copy Markdown
Collaborator

No description provided.

@luiz-santana18 luiz-santana18 marked this pull request as ready for review May 8, 2026 11:45
@luiz-santana18 luiz-santana18 requested a review from skarg May 8, 2026 11:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces initial Zephyr-side configuration and build plumbing for a BACnet Zigbee (BZLL) datalink handler, and tightens up character classification in a couple of shell/settings parsers to avoid undefined behavior with isalpha().

Changes:

  • Added a new bacnet_datalink Kconfig menu and wired it into the subsystem Kconfig tree.
  • Extended the Zephyr build to compile additional BZLL/Zigbee-related sources and propagate BZLL timing settings via compile definitions.
  • Updated isalpha() usage to cast inputs to unsigned char in shell and settings parsing.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
zephyr/subsys/Kconfig Includes the new BACnet datalink Kconfig subtree.
zephyr/subsys/bacnet_shell/bacnet_shell_property.c Fixes isalpha() usage by casting to unsigned char.
zephyr/subsys/bacnet_settings/bacnet_settings.c Fixes isalpha() usage by casting to unsigned char.
zephyr/subsys/bacnet_datalink/Kconfig New Kconfig menu for BACnet datalink/BZLL timing parameters.
zephyr/include/bacnet_settings/bacnet_storage.h Adds <stdio.h> include (currently unused in the header).
zephyr/CMakeLists.txt Adds Zigbee/BZLL source files and exports BZLL timing values as compile definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread zephyr/include/bacnet_settings/bacnet_storage.h Outdated
Comment thread zephyr/subsys/bacnet_datalink/Kconfig Outdated
Comment thread zephyr/CMakeLists.txt Outdated
Comment thread zephyr/subsys/bacnet_datalink/Kconfig Outdated
luiz-santana18 and others added 3 commits May 12, 2026 15:44
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@luiz-santana18 luiz-santana18 merged commit bcbd54e into default May 12, 2026
3 checks passed
@luiz-santana18 luiz-santana18 deleted the feature/bacnet-zigbee-link-layer-handler branch May 12, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants