Feature/bacnet zigbee link layer handler#70
Merged
luiz-santana18 merged 7 commits intoMay 12, 2026
Conversation
…me implicitly declared types changed
…bacnet-zigbee-link-layer-handler
skarg
approved these changes
May 12, 2026
There was a problem hiding this comment.
Pull request overview
This PR introduces initial Zephyr-side configuration and build plumbing for a BACnet Zigbee (BZLL) datalink handler, and tightens up character classification in a couple of shell/settings parsers to avoid undefined behavior with isalpha().
Changes:
- Added a new
bacnet_datalinkKconfig menu and wired it into the subsystem Kconfig tree. - Extended the Zephyr build to compile additional BZLL/Zigbee-related sources and propagate BZLL timing settings via compile definitions.
- Updated
isalpha()usage to cast inputs tounsigned charin shell and settings parsing.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| zephyr/subsys/Kconfig | Includes the new BACnet datalink Kconfig subtree. |
| zephyr/subsys/bacnet_shell/bacnet_shell_property.c | Fixes isalpha() usage by casting to unsigned char. |
| zephyr/subsys/bacnet_settings/bacnet_settings.c | Fixes isalpha() usage by casting to unsigned char. |
| zephyr/subsys/bacnet_datalink/Kconfig | New Kconfig menu for BACnet datalink/BZLL timing parameters. |
| zephyr/include/bacnet_settings/bacnet_storage.h | Adds <stdio.h> include (currently unused in the header). |
| zephyr/CMakeLists.txt | Adds Zigbee/BZLL source files and exports BZLL timing values as compile definitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.