Bus end#576
Merged
raimohanska merged 2 commits intobaconjs:masterfrom May 11, 2015
Merged
Conversation
Contributor
|
Hmm.. the "Bacon.Bus does not plug after end(), second variant" test is still failing. |
Contributor
|
To me it seems that the test is wrong: it "does not plug after end(), second variant", ->
failed = false
busA = new Bacon.Bus()
busB = new Bacon.Bus()
busB.onValue(-> failed = true;)
busB.plug(busA)
busA.push('foo')
busB.end()
expect(failed).to.equal(false)You plug busA before ending busB, so it's correct to pass the "foo" event through, right? |
Member
Author
|
Ah seems, I swapped the lines when "cleaning up the mess". |
Member
Author
|
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes commits from #573