Conversation
johnlees
approved these changes
May 28, 2026
johnlees
left a comment
johnlees
left a comment
Member
There was a problem hiding this comment.
Thanks, this all looks good to me!
Could you make that one clippy change, and also merge the main branch in? Then I think good to go here
| } | ||
| let Some((genome_id, completeness_str)) = line.split_once('\t') else { | ||
| return None; | ||
| }; |
Member
There was a problem hiding this comment.
Would be good to make this clippy change
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 91.63% 91.86% +0.22%
==========================================
Files 17 17
Lines 2964 3121 +157
==========================================
+ Hits 2716 2867 +151
- Misses 248 254 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
added 2 commits
June 16, 2026 11:58
…verted test flag rename
johnlees
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also made sure completeness are given in the correct format