Skip to content

Commit 9cbcbe4

Browse files
committed
fix(ci): electron-builder cwd and club-version job if on dispatch
- Run electron-builder from desktop/ so it finds electron in node_modules. - Add desktop package.json author for electron-builder. - Guard club-calendar-version job when head_commit is null (manual runs + edge pushes). Made-with: Cursor
1 parent e8ba0c7 commit 9cbcbe4

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

.github/workflows/club-calendar-version.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ concurrency:
2121

2222
jobs:
2323
sync:
24-
if: ${{ !contains(github.event.head_commit.message, 'chore(version): club calendar') }}
24+
# head_commit is missing on workflow_dispatch and some pushes — don't dereference .message blindly.
25+
if: ${{ github.event_name != 'push' || github.event.head_commit == null || !contains(github.event.head_commit.message, 'chore(version): club calendar') }}
2526
runs-on: ubuntu-latest
2627
steps:
2728
- name: Checkout (with submodules)

.github/workflows/desktop-build.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,10 @@ jobs:
4242
- name: Install desktop dependencies
4343
run: npm ci --prefix desktop
4444

45+
# electron-builder uses cwd as app root; --prefix only affects npx, not projectDir.
4546
- name: Build portable executable
46-
run: npx --prefix desktop electron-builder --win portable
47+
working-directory: desktop
48+
run: npx electron-builder --win portable
4749

4850
- name: Upload artifact
4951
uses: actions/upload-artifact@v4

desktop/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"name": "sc2-desktop",
33
"version": "1.0.0",
44
"private": true,
5+
"author": "Badger Solar Racing",
56
"main": "main.cjs",
67
"scripts": {
78
"dist": "electron-builder"

0 commit comments

Comments
 (0)