Skip to content

Commit c9ba2a6

Browse files
authored
Merge pull request #19 from badgerloop-software/fix/audit-vulnerabilities
fix(deps): resolve npm audit findings on Expo root
2 parents 0710d96 + 708f114 commit c9ba2a6

3 files changed

Lines changed: 66 additions & 77 deletions

File tree

docs/chase-car-dashboard-git-subtree.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,3 +54,11 @@ rm -rf ../public/classic-dashboard && cp -a build ../public/classic-dashboard
5454
## Force-push warning
5555

5656
Rewriting `main` to insert this history retroactively would disrupt existing clones. New history was added on a dedicated branch with a merge that preserves upstream authors going forward.
57+
58+
## npm audit / security note
59+
60+
`classic-dashboard/` is a **separate Create React App** app (`react-scripts@4`). It has its **own** `package.json` and `node_modules` and is **not** installed when you run `npm install` at the repo root. Root-level `npm audit` therefore reflects **Expo / mobile** dependencies only.
61+
62+
If you `cd classic-dashboard && npm install`, `npm audit` typically reports **many** findings (often **hundreds**), mostly from the old **webpack / webpack-dev-server / jest** stack pinned by CRA 4. Clearing them usually requires a **major upgrade** to `react-scripts@5` (breaking) or replacing the build toolchain. Many reported issues apply to **local dev** (`npm start`), not to the **static production build** copied into `public/classic-dashboard/`, which does not ship the dev server.
63+
64+
For dependency hygiene on the classic tree, prefer fixing **upstream** `chase-car-dashboard` and then `git subtree pull`, or plan a dedicated CRA 5 / Vite migration in that repo.

package-lock.json

Lines changed: 57 additions & 76 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
"ws": "^8.20.0"
5959
},
6060
"overrides": {
61-
"tar": ">=7.5.4"
61+
"tar": ">=7.5.11"
6262
},
6363
"private": true,
6464
"expo": {

0 commit comments

Comments
 (0)