fix(pages): inject <base href> for classic-dashboard on GitHub Pages

sbasu107 · sbasu107 · commit f57abb632820 · 2026-04-05T22:11:33.000-05:00
Direct visits to /repo/classic-dashboard (no trailing slash) resolve ./static
relative to /repo and load no JS. Inject base only in deploy workflow before
expo export so local dev and desktop export keep relative asset paths.

Made-with: Cursor
diff --git a/.github/workflows/deploy-pages.yml b/.github/workflows/deploy-pages.yml
@@ -62,6 +62,13 @@ jobs:
       - name: Install dependencies
         run: npm ci
 
+      # CRA uses relative ./static/* ; without a trailing slash, /repo/classic-dashboard resolves
+      # ./static to /repo/static (wrong). <base href> fixes direct links to .../classic-dashboard
+      - name: Classic dashboard base URL for Pages
+        env:
+          CLASSIC_BASE_HREF: /${{ github.event.repository.name }}/classic-dashboard
+        run: node scripts/inject-classic-dashboard-base.cjs
+
       - name: Export web (static)
         env:
           EXPO_PUBLIC_BASE_PATH: /${{ github.event.repository.name }}
diff --git a/scripts/inject-classic-dashboard-base.cjs b/scripts/inject-classic-dashboard-base.cjs
@@ -0,0 +1,28 @@
+/**
+ * GitHub Pages only: insert <base href=".../classic-dashboard/"> so direct visits to
+ * /repo/classic-dashboard (no trailing slash) still resolve ./static/* correctly.
+ * Local dev and desktop export keep the committed index.html without this tag.
+ */
+const fs = require('fs');
+const path = require('path');
+
+const base = (process.env.CLASSIC_BASE_HREF || '').trim();
+if (!base) {
+  process.exit(0);
+}
+
+const indexPath = path.join(__dirname, '..', 'public', 'classic-dashboard', 'index.html');
+if (!fs.existsSync(indexPath)) {
+  console.warn('inject-classic-dashboard-base: skip, missing', indexPath);
+  process.exit(0);
+}
+
+let html = fs.readFileSync(indexPath, 'utf8');
+if (/<base\s/i.test(html)) {
+  process.exit(0);
+}
+
+const href = base.endsWith('/') ? base : `${base}/`;
+html = html.replace(/<head>/i, `<head><base href="${href}" />`);
+fs.writeFileSync(indexPath, html);
+console.log('inject-classic-dashboard-base: set base href to', href);
