Skip to content

Commit a5761af

Browse files
committed
Fix lint in GitHub release-by-branch service
Reorder static render before transform and fix Prettier formatting in spec and tester files.
1 parent 45ca6ae commit a5761af

2 files changed

Lines changed: 18 additions & 23 deletions

File tree

services/github/github-release-branch.service.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@ export default class GithubReleaseBranch extends GithubAuthV3Service {
6363
return undefined
6464
}
6565

66-
transform({ release, branch }) {
67-
const { tag_name: version, prerelease: isPrerelease } = release
68-
return { version, isPrerelease, branch }
69-
}
70-
7166
static render({ version, isPrerelease, branch }) {
7267
return renderVersionBadge({
7368
version,
@@ -76,6 +71,10 @@ export default class GithubReleaseBranch extends GithubAuthV3Service {
7671
tag: branch,
7772
})
7873
}
74+
transform({ release, branch }) {
75+
const { tag_name: version, prerelease: isPrerelease } = release
76+
return { version, isPrerelease, branch }
77+
}
7978

8079
async fetchPage({ user, repo, page }) {
8180
return this._requestJson({

services/github/github-release-branch.service.spec.js

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,20 @@ describe('GithubReleaseBranch service', function () {
1616
given({ releases, branch: '2.x', includePrereleases: false }).expect(
1717
undefined,
1818
)
19-
given(
20-
{
21-
releases: [
22-
{ tag_name: 'v2.0.0-beta', target_commitish: 'main', prerelease: true },
23-
],
24-
branch: 'main',
25-
includePrereleases: false,
26-
},
27-
).expect(undefined)
28-
given(
29-
{
30-
releases: [
31-
{ tag_name: 'v2.0.0-beta', target_commitish: 'main', prerelease: true },
32-
],
33-
branch: 'main',
34-
includePrereleases: true,
35-
},
36-
).expect({
19+
given({
20+
releases: [
21+
{ tag_name: 'v2.0.0-beta', target_commitish: 'main', prerelease: true },
22+
],
23+
branch: 'main',
24+
includePrereleases: false,
25+
}).expect(undefined)
26+
given({
27+
releases: [
28+
{ tag_name: 'v2.0.0-beta', target_commitish: 'main', prerelease: true },
29+
],
30+
branch: 'main',
31+
includePrereleases: true,
32+
}).expect({
3733
tag_name: 'v2.0.0-beta',
3834
target_commitish: 'main',
3935
prerelease: true,

0 commit comments

Comments
 (0)