refactor: use undici for HTTPS requests

Author: jviide

.changeset/new-sloths-tie.md

@@ -0,0 +1,5 @@
+---
+"@badrap/libapp": patch
+---
+
+Use `undici` for HTTPS requests

package.json

@@ -34,11 +34,13 @@
     "tag": "changeset tag"
   },
   "dependencies": {
-    "@badrap/valita": "^0.5.0"
+    "@badrap/valita": "^0.5.0",
+    "undici": "^8.2.0"
   },
   "devDependencies": {
     "@changesets/changelog-github": "^0.6.0",
     "@changesets/cli": "^2.31.0",
+    "@types/node": "^25.6.0",
     "oxfmt": "^0.47.0",
     "oxlint": "^1.62.0",
     "oxlint-tsgolint": "^0.22.1",

pnpm-lock.yaml

@@ -1,4 +1,5 @@
 import * as v from "@badrap/valita";
+import { fetch, Headers } from "undici";
 
 const json = JSON.stringify;
 
@@ -69,14 +70,6 @@ function joinPath(path: string[]): string {
     .join("/");
 }
 
-async function dump(stream: ReadableStream | null) {
-  if (stream) {
-    for await (const _ of stream) {
-      // pass
-    }
-  }
-}
-
 export interface ClientConfig {
   url: string;
   token: string;
@@ -123,40 +116,47 @@ export class Client {
       headers,
       body,
     });
-    const contentType = response.headers.get("content-type");
-    const isJSON = /^application\/json\s*(;|$)/.test(contentType ?? "");
-
-    if (response.status >= 400 && response.status < 600) {
-      if (isJSON) {
-        const rawBody: unknown = await response.json();
-
-        const body = APIErrorBody.try(rawBody, { mode: "strip" });
-        if (body.ok) {
-          throw new APIError(
-            response.status,
-            response.statusText,
-            body.value.error.code,
-            body.value.error.reason,
-          );
+    try {
+      const contentType = response.headers.get("content-type");
+      const isJSON = /^application\/json\s*(;|$)/.test(contentType ?? "");
+
+      if (response.status >= 400 && response.status < 600) {
+        if (isJSON) {
+          const rawBody: unknown = await response.json();
+
+          const body = APIErrorBody.try(rawBody, { mode: "strip" });
+          if (body.ok) {
+            throw new APIError(
+              response.status,
+              response.statusText,
+              body.value.error.code,
+              body.value.error.reason,
+            );
+          }
         }
-      } else {
-        await dump(response.body);
+        throw new HTTPError(response.status, response.statusText);
       }
-      throw new HTTPError(response.status, response.statusText);
-    }
 
-    let json: unknown = undefined;
-    if (isJSON) {
-      json = await response.json();
-    } else {
-      await dump(response.body);
-    }
+      let json: unknown = undefined;
+      if (isJSON) {
+        json = await response.json();
+      }
 
-    const etag = response.headers.get("etag") ?? undefined;
-    if (!options.responseType) {
-      return { body: json as v.Infer<T>, etag };
+      const etag = response.headers.get("etag") ?? undefined;
+      if (!options.responseType) {
+        return { body: json as v.Infer<T>, etag };
+      }
+      return {
+        body: options.responseType.parse(json, { mode: "strip" }),
+        etag,
+      };
+    } finally {
+      if (!response.bodyUsed && response.body) {
+        for await (const _ of response.body) {
+          // Dump the response data.
+        }
+      }
     }
-    return { body: options.responseType.parse(json, { mode: "strip" }), etag };
   }
 
   async request<T extends v.Type>(

src/api/client.ts

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "target": "es2022",
     "module": "node20",
-    "types": [],
+    "types": ["node"],
     "libReplacement": false,
     "declaration": true,
     "sourceMap": true,