LoRAServerSocket refactor and CI workflow improvements#53
Merged
Conversation
- Added newlines for better readability in base_model_user_sample_script.py, lora_contributor_sample_script.py, and verify_proofs.py. - Reformatted argument definitions for clarity in all affected scripts.
- Adjusted the installation command for Python dependencies to use "src/[dev]". - Renamed the pytest job to "tests & coverage" for clarity. - Removed the safety check step from the linting process.
- Modified the CI workflow to install development dependencies from "src/[dev]". - Corrected the README file path in pyproject.toml from "../README.md" to "../readme.md". - Added optional development dependencies in pyproject.toml for better project structure.
- Renamed the lint job from "Lint & Security" to "lint" for uniformity. - Updated the test command to run from the "tests/" directory instead of "src/tests/" for improved structure.
- Adjusted the coverage failure threshold in the test command to enhance flexibility in test coverage requirements.
- Updated string formatting from single quotes to double quotes in several files for uniformity. - Added newlines for improved readability in multiple functions and classes across various modules. - Enhanced error messages and print statements for better clarity during execution.
- Added a `stop_timeout` parameter to the `LoRAServerSocket` class for configurable socket timeout. - Removed unused imports in `__init__.py` files across base_model_user_mpi and lora_contributor_mpi modules for improved clarity and reduced clutter.
- Changed the workflow name from "python-ci" to "CI" for improved clarity and consistency with naming conventions.
- Reformatted the constructor of the `LoRAServerSocket` class to enhance clarity by using multi-line argument definitions. - Updated the `lora_contributor_sample_script.py` for consistent formatting of the `LoRAServerSocket` instantiation.
BidhanRoy
approved these changes
Nov 19, 2025
Signed-off-by: Marcos Villagra <71292159+mdvillagra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR improves the CI, code readability in key components, and streamline local development and testing workflows.
More details:
LoRAServerSocketinitialization and related imports to improve readability and maintainability..gitignoreto include.pytest_cache, keeping the repo cleaner and preventing unnecessary files from being tracked.Note
Add GitHub Actions CI for lint/tests with 30% coverage, introduce dev extras, and refactor LoRA MPI sockets/client and scripts with timeouts and cleaner structure.
ci.ymlwith Python 3.11 linting (ruff) and tests + coverage (--cov-fail-under=30).devoptional dependencies (ruff,pytest,pytest-cov) insrc/pyproject.toml.readmeto../readme.md.LoRAServerSocket: support configurablestop_timeoutand apply to server socket timeout; cleanup imports and responses.BaseModelClient/comm: patching flow retained; networking timeout handling and formatting improvements.generate_proofsdirectly; streamline ONNX/JSON export (export_lora_onnx_json_mpi).base_model_user_sample_script.py,lora_contributor_sample_script.py(usestop_timeout=1.0), andverify_proofs.py.polynomial_commit.py) with hiding Merkle commitments and verification API..coverageis ignored in.gitignore.Written by Cursor Bugbot for commit ddceddb. This will update automatically on new commits. Configure here.