fix

Author: bajrangCoder

src/cm/touchSelectionMenu.js

@@ -132,6 +132,7 @@ class TouchSelectionMenuController {
 	#isScrolling = false;
 	#isPointerInteracting = false;
 	#shiftSelectionSession = null;
+	#pendingShiftSelectionClick = null;
 	#menuActive = false;
 	#menuRequested = false;
 	#enabled = true;
@@ -176,13 +177,15 @@ class TouchSelectionMenuController {
 		cancelAnimationFrame(this.#stateSyncRaf);
 		this.#stateSyncRaf = 0;
 		this.#shiftSelectionSession = null;
+		this.#pendingShiftSelectionClick = null;
 		this.#hideMenu(true);
 	}
 
 	setEnabled(enabled) {
 		this.#enabled = !!enabled;
 		if (this.#enabled) return;
 		this.#shiftSelectionSession = null;
+		this.#pendingShiftSelectionClick = null;
 		this.#menuRequested = false;
 		this.#isPointerInteracting = false;
 		this.#isScrolling = false;
@@ -254,6 +257,7 @@ class TouchSelectionMenuController {
 	onSessionChanged() {
 		if (!this.#enabled) return;
 		this.#shiftSelectionSession = null;
+		this.#pendingShiftSelectionClick = null;
 		this.#menuRequested = false;
 		this.#isPointerInteracting = false;
 		this.#isScrolling = false;
@@ -349,6 +353,11 @@ class TouchSelectionMenuController {
 			selection: EditorSelection.range(session.anchor, head),
 			userEvent: "select.extend",
 		});
+		this.#pendingShiftSelectionClick = {
+			x: event.clientX,
+			y: event.clientY,
+			timeStamp: event.timeStamp,
+		};
 		event.preventDefault();
 	}
 
@@ -359,6 +368,24 @@ class TouchSelectionMenuController {
 		return !!this.#isShiftSelectionActive(event);
 	}
 
+	consumePendingShiftSelectionClick(event) {
+		const pending = this.#pendingShiftSelectionClick;
+		this.#pendingShiftSelectionClick = null;
+		if (!pending || !this.#enabled) return false;
+		if (event.timeStamp - pending.timeStamp > TAP_MAX_DELAY) return false;
+		if (
+			Math.hypot(event.clientX - pending.x, event.clientY - pending.y) >
+			TAP_MAX_DISTANCE
+		) {
+			return false;
+		}
+		const target = event.target;
+		if (!(target instanceof Node) || !this.#view.dom.contains(target))
+			return false;
+		if (this.#isIgnoredPointerTarget(target)) return false;
+		return true;
+	}
+
 	#shouldShowMenu() {
 		if (this.#isScrolling || this.#isPointerInteracting || !this.#view.hasFocus)
 			return false;

src/lib/editorManager.js

@@ -198,6 +198,15 @@ async function EditorManager($header, $body) {
 		if (!appSettings.value.shiftClickSelection) return false;
 		return !!event?.shiftKey || quickTools?.$footer?.dataset?.shift != null;
 	};
+	const shiftClickSelectionExtension = EditorView.domEventHandlers({
+		click(event) {
+			if (!touchSelectionController?.consumePendingShiftSelectionClick(event)) {
+				return false;
+			}
+			event.preventDefault();
+			return true;
+		},
+	});
 	const touchSelectionUpdateExtension = EditorView.updateListener.of(
 		(update) => {
 			if (!touchSelectionController) return;
@@ -755,6 +764,7 @@ async function EditorManager($header, $body) {
 			commandKeymapExtension: getCommandKeymapExtension(),
 			themeExtension: themeCompartment.of(oneDark),
 			pointerCursorVisibilityExtension,
+			shiftClickSelectionExtension,
 			touchSelectionUpdateExtension,
 			searchExtension: search(),
 			// Ensure read-only can be toggled later via compartment
@@ -1117,6 +1127,7 @@ async function EditorManager($header, $body) {
 			// keep compartment in the state to allow dynamic theme changes later
 			themeExtension: themeCompartment.of(oneDark),
 			pointerCursorVisibilityExtension,
+			shiftClickSelectionExtension,
 			touchSelectionUpdateExtension,
 			searchExtension: search(),
 			// Keep dynamic compartments across state swaps