Skip to content

Commit 86b5b34

Browse files
committed
fix(settings): address review feedback
1 parent fbe364e commit 86b5b34

34 files changed

+107
-39
lines changed

src/components/searchbar/index.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,11 @@ function searchBar($list, setHide, onhideCb, searchFunction) {
133133

134134
if (!hasGroups) return result.map(cloneSearchItem);
135135

136-
const countLabel = `${result.length} ${result.length === 1 ? "RESULT" : "RESULTS"}`;
136+
const countLabel = `${result.length} ${
137+
result.length === 1
138+
? strings["search result label singular"]
139+
: strings["search result label plural"]
140+
}`;
137141
const content = [
138142
<div className="settings-search-summary">{countLabel}</div>,
139143
];

src/lang/ar-ye.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,5 +697,7 @@
697697
"settings-info-preview-use-current-file": "Prefer the current file when starting preview.",
698698
"settings-info-terminal-convert-eol": "Convert line endings when pasting or rendering terminal output.",
699699
"settings-note-formatter-settings": "Assign a formatter to each language. Install formatter plugins to unlock more options.",
700-
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment."
700+
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment.",
701+
"search result label singular": "result",
702+
"search result label plural": "results"
701703
}

src/lang/be-by.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,5 +699,7 @@
699699
"settings-info-preview-use-current-file": "Prefer the current file when starting preview.",
700700
"settings-info-terminal-convert-eol": "Convert line endings when pasting or rendering terminal output.",
701701
"settings-note-formatter-settings": "Assign a formatter to each language. Install formatter plugins to unlock more options.",
702-
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment."
702+
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment.",
703+
"search result label singular": "result",
704+
"search result label plural": "results"
703705
}

src/lang/bn-bd.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,5 +698,7 @@
698698
"settings-info-preview-use-current-file": "Prefer the current file when starting preview.",
699699
"settings-info-terminal-convert-eol": "Convert line endings when pasting or rendering terminal output.",
700700
"settings-note-formatter-settings": "Assign a formatter to each language. Install formatter plugins to unlock more options.",
701-
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment."
701+
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment.",
702+
"search result label singular": "result",
703+
"search result label plural": "results"
702704
}

src/lang/cs-cz.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,5 +698,7 @@
698698
"settings-info-preview-use-current-file": "Prefer the current file when starting preview.",
699699
"settings-info-terminal-convert-eol": "Convert line endings when pasting or rendering terminal output.",
700700
"settings-note-formatter-settings": "Assign a formatter to each language. Install formatter plugins to unlock more options.",
701-
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment."
701+
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment.",
702+
"search result label singular": "result",
703+
"search result label plural": "results"
702704
}

src/lang/de-de.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,5 +698,7 @@
698698
"settings-info-preview-use-current-file": "Prefer the current file when starting preview.",
699699
"settings-info-terminal-convert-eol": "Convert line endings when pasting or rendering terminal output.",
700700
"settings-note-formatter-settings": "Assign a formatter to each language. Install formatter plugins to unlock more options.",
701-
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment."
701+
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment.",
702+
"search result label singular": "result",
703+
"search result label plural": "results"
702704
}

src/lang/en-us.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,5 +698,7 @@
698698
"settings-info-preview-use-current-file": "Prefer the current file when starting preview.",
699699
"settings-info-terminal-convert-eol": "Convert line endings when pasting or rendering terminal output.",
700700
"settings-note-formatter-settings": "Assign a formatter to each language. Install formatter plugins to unlock more options.",
701-
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment."
701+
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment.",
702+
"search result label singular": "result",
703+
"search result label plural": "results"
702704
}

src/lang/es-sv.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,5 +698,7 @@
698698
"settings-info-preview-use-current-file": "Prefer the current file when starting preview.",
699699
"settings-info-terminal-convert-eol": "Convert line endings when pasting or rendering terminal output.",
700700
"settings-note-formatter-settings": "Assign a formatter to each language. Install formatter plugins to unlock more options.",
701-
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment."
701+
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment.",
702+
"search result label singular": "result",
703+
"search result label plural": "results"
702704
}

src/lang/fr-fr.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,5 +698,7 @@
698698
"settings-info-preview-use-current-file": "Prefer the current file when starting preview.",
699699
"settings-info-terminal-convert-eol": "Convert line endings when pasting or rendering terminal output.",
700700
"settings-note-formatter-settings": "Assign a formatter to each language. Install formatter plugins to unlock more options.",
701-
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment."
701+
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment.",
702+
"search result label singular": "result",
703+
"search result label plural": "results"
702704
}

src/lang/he-il.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,5 +699,7 @@
699699
"settings-info-preview-use-current-file": "Prefer the current file when starting preview.",
700700
"settings-info-terminal-convert-eol": "Convert line endings when pasting or rendering terminal output.",
701701
"settings-note-formatter-settings": "Assign a formatter to each language. Install formatter plugins to unlock more options.",
702-
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment."
702+
"settings-note-lsp-settings": "Language servers add autocomplete, diagnostics, hover details, and more. You can install, update, or define custom servers here. Managed installers run inside the terminal/proot environment.",
703+
"search result label singular": "result",
704+
"search result label plural": "results"
703705
}

0 commit comments

Comments
 (0)