address the reviews

Author: bajrangCoder

src/handlers/editorFileTab.js

@@ -310,12 +310,11 @@ function updateFileList($parent) {
 
 		if (nextPinnedState !== undefined) {
 			draggedFile.setPinnedState(nextPinnedState, { reorder: false });
+			if (typeof editorManager.normalizePinnedTabOrder === "function") {
+				editorManager.normalizePinnedTabOrder(editorManager.files);
+			}
 		}
 	}
-
-	if (typeof editorManager.normalizePinnedTabOrder === "function") {
-		editorManager.normalizePinnedTabOrder(editorManager.files);
-	}
 }
 
 /**

src/lib/editorFile.js

@@ -777,7 +777,7 @@ export default class EditorFile {
 	}
 
 	setPinnedState(value, options = {}) {
-		const { reorder = true, emit = true } = options;
+		const { reorder = false, emit = true } = options;
 		value = !!value;
 		if (this.#pinned === value) return value;
 
@@ -1529,7 +1529,10 @@ export default class EditorFile {
 
 		return tag("span", {
 			className: "licons pin",
-			title: strings["pinned tab"] || "Pinned tab",
+			title: strings["unpin tab"] || "Unpin tab",
+			dataset: {
+				action: "toggle-pin",
+			},
 		});
 	}
 
@@ -1581,6 +1584,10 @@ function tabOnclick(e) {
 		this.remove();
 		return;
 	}
+	if (action === "toggle-pin") {
+		this.togglePinned();
+		return;
+	}
 	this.makeActive();
 }
 

src/lib/editorManager.js

@@ -1792,16 +1792,7 @@ async function EditorManager($header, $body) {
 	}
 
 	function moveFileByPinnedState(file) {
-		const currentIndex = manager.files.indexOf(file);
-		if (currentIndex === -1) return;
-
-		const targetIndex = file.pinned ? 0 : getPinnedInsertIndex(file);
-		if (currentIndex !== targetIndex) {
-			manager.files.splice(currentIndex, 1);
-			manager.files.splice(targetIndex, 0, file);
-		}
-
-		syncOpenFileList();
+		if (!manager.files.includes(file)) return;
 		if (manager.activeFile?.id === file.id) {
 			file.tab.scrollIntoView();
 		}