fixed more linting errors (3)

Author: bajrangCoder

src/fileSystem/externalFs.js

@@ -12,7 +12,7 @@ const externalFs = {
 	},
 
 	async writeFile(filename, data) {
-		return new Promise(async (resolve, reject) => {
+		return new Promise((resolve, reject) => {
 			sdcard.write(filename, data, resolve, reject);
 		});
 	},

src/fileSystem/ftp.js

@@ -315,7 +315,7 @@ class FtpClient {
 	get #cacheFile() {
 		return Url.join(
 			CACHE_STORAGE,
-			"ftp" + Url.join(this.#origin, this.#path).hashCode(),
+			`ftp${Url.join(this.#origin, this.#path).hashCode()}`,
 		);
 	}
 

src/fileSystem/sftp.js

@@ -32,7 +32,7 @@ class SftpClient {
 		this.#hostname = hostname;
 		this.#port = port;
 		this.#username = username;
-		this.#authenticationType = !!authentication.keyFile ? "key" : "password";
+		this.#authenticationType = authentication.keyFile ? "key" : "password";
 		this.#keyFile = authentication.keyFile;
 		this.#passPhrase = authentication.passPhrase;
 		this.#password = authentication.password;
@@ -78,13 +78,13 @@ class SftpClient {
 					sftp.lsDir(
 						path,
 						(res) => {
-							res.forEach((file) => {
+							for (const file of res) {
 								file.url = Url.join(this.#base, file.url);
 								file.type = mimeType.lookup(filename);
 								if (file.isLink) {
 									file.linkTarget = Url.join(this.#base, file.linkTarget);
 								}
-							});
+							}
 							resolve(res);
 						},
 						(err) => {
@@ -357,8 +357,8 @@ class SftpClient {
 					await this.#setStat();
 					sftp.rm(
 						this.#safeName(filename),
-						this.#stat.isDirectory ? true : false,
-						this.#stat.isDirectory ? true : false,
+						this.#stat.isDirectory,
+						this.#stat.isDirectory,
 						(_res) => {
 							resolve(fullFilename);
 						},
@@ -565,7 +565,7 @@ class SftpClient {
 	#getLocalname(filename) {
 		return Url.join(
 			CACHE_STORAGE,
-			"sftp" + Url.join(this.#base, filename).hashCode(),
+			`sftp${Url.join(this.#base, filename).hashCode()}`,
 		);
 	}
 

src/handlers/keyboard.js

@@ -154,7 +154,9 @@ keyboardHandler.off = (eventName, callback) => {
  */
 function emit(eventName) {
 	if (!event[eventName]) return;
-	event[eventName].forEach((cb) => cb());
+	for (const cb of event[eventName]) {
+		cb();
+	}
 }
 
 /**

src/handlers/quickTools.js

@@ -120,7 +120,7 @@ export default function actions(action, value) {
 		setInput();
 		value = !state[action];
 		state[action] = value;
-		events[action].forEach((cb) => cb(value));
+		for (const cb of events[action]) cb(value);
 		if (Object.values(state).includes(true)) {
 			$input.focus();
 		} else if (input) {
@@ -351,9 +351,11 @@ function updateSearchState() {
 	if (regex) {
 		const value = editor.getValue();
 		const offset = editor.session.doc.positionToIndex(editor.selection.anchor);
-		let last = (regex.lastIndex = 0);
+		regex.lastIndex = 0;
+		let last = 0;
 		let m;
-		while ((m = regex.exec(value))) {
+		m = regex.exec(value);
+		while (m) {
 			all++;
 			last = m.index;
 			if (last <= offset) before++;
@@ -362,6 +364,7 @@ function updateSearchState() {
 				regex.lastIndex = last += 1;
 				if (last >= value.length) break;
 			}
+			m = regex.exec(value);
 		}
 	}
 	$searchTotal.textContent = all > MAX_COUNT ? "999+" : all;
@@ -402,13 +405,13 @@ function focusEditor() {
 
 function resetKeys() {
 	state.shift = false;
-	events.shift.forEach((cb) => cb(false));
+	for (const cb of events.shift) cb(false);
 	state.alt = false;
-	events.alt.forEach((cb) => cb(false));
+	for (const cb of events.alt) cb(false);
 	state.ctrl = false;
-	events.ctrl.forEach((cb) => cb(false));
+	for (const cb of events.ctrl) cb(false);
 	state.meta = false;
-	events.meta.forEach((cb) => cb(false));
+	for (const cb of events.meta) cb(false);
 	input.focus();
 }
 

src/handlers/windowResize.js

@@ -70,5 +70,7 @@ function onResize() {
  */
 function emit(eventName) {
 	if (!event[eventName]) return;
-	event[eventName].forEach((cb) => cb());
+	for (const cb of event[eventName]) {
+		cb();
+	}
 }

src/palettes/commandPalette/index.js

@@ -15,7 +15,7 @@ export default async function commandPalette() {
 	function generateHints() {
 		const hints = [];
 
-		commands.forEach(({ name, description, bindKey }) => {
+		for (const { name, description, bindKey } of commands) {
 			/**
 			 * @param {boolean} recentlyUsed Is the command recently used
 			 * @returns {{value: string, text: string}}
@@ -26,10 +26,10 @@ export default async function commandPalette() {
 			});
 			if (recentCommands.commands.includes(name)) {
 				hints.unshift(item(true));
-				return;
+				continue;
 			}
 			hints.push(item());
-		});
+		}
 
 		return hints;
 	}

src/palettes/findFile/index.js

@@ -28,7 +28,7 @@ export default async function findFile() {
 		hintsModification = hints;
 		const list = [];
 
-		editorManager.files.forEach((file) => {
+		for (const file of editorManager.files) {
 			const { uri, name } = file;
 			let { location = "" } = file;
 
@@ -37,7 +37,7 @@ export default async function findFile() {
 			}
 
 			list.push(hintItem(name, location, uri));
-		});
+		}
 
 		list.push(...files(hintItem));
 		return list;

src/settings/backupRestore.js

@@ -10,8 +10,7 @@ import Url from "utils/Url";
 import helpers from "utils/helpers";
 
 function backupRestore() {
-	const title =
-		strings.backup.capitalize() + "/" + strings.restore.capitalize();
+	const title = `${strings.backup.capitalize()}/${strings.restore.capitalize()}`;
 	const items = [
 		{
 			key: "backup",

src/settings/mainSettings.js

@@ -62,7 +62,7 @@ export default function mainSettings() {
 		},
 		{
 			key: "backup-restore",
-			text: strings.backup.capitalize() + "/" + strings.restore.capitalize(),
+			text: `${strings.backup.capitalize()}/${strings.restore.capitalize()}`,
 			icon: "cached",
 		},
 		{
@@ -72,7 +72,7 @@ export default function mainSettings() {
 		},
 		{
 			key: "plugins",
-			text: strings["plugins"],
+			text: strings.plugins,
 			icon: "extension",
 		},
 		{
@@ -89,12 +89,12 @@ export default function mainSettings() {
 		},
 		{
 			key: "editSettings",
-			text: `${strings["edit"]} settings.json`,
+			text: `${strings.edit} settings.json`,
 			icon: "edit",
 		},
 		{
 			key: "changeLog",
-			text: `${strings["changelog"]}`,
+			text: `${strings.changelog}`,
 			icon: "update",
 		},
 	];
@@ -151,7 +151,7 @@ export default function mainSettings() {
 				break;
 			}
 
-			case "reset":
+			case "reset": {
 				const confirmation = await confirm(
 					strings.warning,
 					strings["restore default settings"],
@@ -161,6 +161,7 @@ export default function mainSettings() {
 					location.reload();
 				}
 				break;
+			}
 
 			case "removeads":
 				try {