Improve internal codebase

Author: nyamsprod

src/Dictionary.php

@@ -127,12 +127,15 @@ public static function fromHttpValue(Stringable|string $httpValue): self
 
     public function toHttpValue(): string
     {
-        $formatter = static fn (StructuredField $member, string $key): string => match (true) {
-            $member instanceof ValueAccess && $member instanceof ParameterAccess && true === $member->value() => $key.$member->parameters()->toHttpValue(),
-            default => $key.'='.$member->toHttpValue(),
-        };
+        $members = [];
+        foreach ($this->members as $key => $member) {
+            $members[] = match (true) {
+                $member instanceof ValueAccess && true === $member->value() => $key.$member->parameters()->toHttpValue(),
+                default => $key.'='.$member->toHttpValue(),
+            };
+        }
 
-        return implode(', ', array_map($formatter, $this->members, array_keys($this->members)));
+        return implode(', ', $members);
     }
 
     public function __toString(): string

src/InnerList.php

@@ -11,6 +11,7 @@
 use Stringable;
 use function array_filter;
 use function array_map;
+use function array_replace;
 use function array_splice;
 use function array_values;
 use function count;
@@ -260,14 +261,11 @@ public function replace(int $key, StructuredField|Token|ByteSequence|DateTimeInt
         }
 
         $member = self::filterMember($member);
-        if ($member == $this->members[$offset]) {
+        if ($member->toHttpValue() === $this->members[$offset]->toHttpValue()) {
             return $this;
         }
 
-        $members = $this->members;
-        $members[$offset] = self::filterMember($member);
-
-        return new self($members, $this->parameters);
+        return new self(array_replace($this->members, [$offset => $member]), $this->parameters);
     }
 
     public function remove(string|int ...$keys): static

src/OuterList.php

@@ -10,6 +10,7 @@
 use Stringable;
 use function array_filter;
 use function array_map;
+use function array_replace;
 use function array_splice;
 use function array_values;
 use function count;
@@ -224,14 +225,11 @@ public function replace(int $key, iterable|StructuredField|Token|ByteSequence|Da
         }
 
         $member = self::filterMember($member);
-        if ($member == $this->members[$offset]) {
+        if ($member->toHttpValue() === $this->members[$offset]->toHttpValue()) {
             return $this;
         }
 
-        $members = $this->members;
-        $members[$offset] = self::filterMember($member);
-
-        return new self(...$members);
+        return new self(...array_replace($this->members, [$offset => $member]));
     }
 
     public function remove(string|int ...$keys): static