Revert InnerList and OuterList named constructors names

Author: nyamsprod

CHANGELOG.md

@@ -6,16 +6,13 @@ All Notable changes to `bakame/http-strucured-fields` will be documented in this
 
 ### Added
 
-- `Item::fromTimestamp`, `Item::fromDateFormat` to improve item instantiation with dates.
+- `Item::fromTimestamp`, `Item::fromDateFormat`, `Item::fromDateString` to improve item instantiation with dates.
 - `ParameterAccess::parameter` to ease parameter members value access.
-- `InnerList::fromAssociativeParameters`
-- `InnerList::fromPairParameters`
+- `InnerList::fromAssociativeParameters`, `InnerList::fromPairParameters`  to improve item instantiation with parameters.
 - **[BC Break]** `ParameterAccess::withoutAllParameters` is renamed `ParameterAccess::withoutAnyParameter`.
 - **[BC Break]** `OrderedList` is renamed `OuterList`.
 - **[BC Break]** `MemberContainer::remove` methods get added to the interface.
 - **[BC Break]** `MemberContainer::keys` method added to the interface.
-- **[BC Break]** `InnerList::from` is renamed `InnerList::fromMembers`.
-- **[BC Break]** `OuterList::from` is renamed `OuterList::fromMembers`.
 
 ### Fixed
 
@@ -35,11 +32,9 @@ All Notable changes to `bakame/http-strucured-fields` will be documented in this
 
 - **[BC Break]** `OrderedList` is removed, use `OuterList` instead.
 - **[BC Break]**  `ParameterAccess::withoutAllParameters` is removed, use `ParameterAccess::withoutAnyParameters` instead.
-- **[BC Break]**  remove the `$parameters` argument from all `Item` named constuctore except from `Item::from`.
-- **[BC Break]**  remove `InnerList::fromList`, use `InnerList::from` instead.
+- **[BC Break]**  remove the `$parameters` argument from all `Item` named constuctors except from `Item::from`.
+- **[BC Break]**  remove `InnerList::fromList`, use `InnerList::fromAssociativeParameters` or `InnerList::fromPairParameters` instead.
 - **[BC Break]**  remove `OuterList::fromList`, use `OuterList::from` instead.
-- **[BC Break]**  remove `InnerList::from` use `InnerList::fromMembers`.
-- **[BC Break]**  remove `OuterList::from` use `OuterList::fromMembers`.
 - 
 ## [0.7.0] - 2023-02-06
 

README.md

@@ -180,7 +180,7 @@ To Create `OuterList` and `InnerList` instances you can use the `fromMembers` na
 use Bakame\Http\StructuredFields\InnerList;
 use Bakame\Http\StructuredFields\Item;
 
-$list = InnerList::fromMembers(
+$list = InnerList::from(
     Item::fromDecodedByteSequence('Hello World'),
     42.0,
     42
@@ -195,7 +195,7 @@ Once again, builder methods exist on both classes to ease container construction
 use Bakame\Http\StructuredFields\InnerList;
 use Bakame\Http\StructuredFields\Item;
 
-$list = InnerList::fromMembers()
+$list = InnerList::from()
     ->unshift('42')
     ->push(42)
     ->insert(1, 42.0)

phpstan.neon

@@ -8,4 +8,5 @@ parameters:
     paths:
         - src
     ignoreErrors:
+        - '#it_fails_to_create_an_item_from_an_array_of_pairs\(\)#'
     reportUnmatchedIgnoredErrors: true

src/Dictionary.php

@@ -51,7 +51,7 @@ private static function filterMember(iterable|StructuredField|Token|ByteSequence
         return match (true) {
             ($member instanceof MemberList && $member instanceof ParameterAccess),
             $member instanceof Value => $member,
-            is_iterable($member) => InnerList::fromMembers(...$member),
+            is_iterable($member) => InnerList::from(...$member),
             default => Item::from($member),
         };
     }

src/InnerList.php

@@ -46,7 +46,7 @@ private static function filterMember(StructuredField|Token|ByteSequence|DateTime
     /**
      * Returns a new instance.
      */
-    public static function fromMembers(Value|Token|ByteSequence|DateTimeInterface|Stringable|string|int|float|bool ...$members): static
+    public static function from(Value|Token|ByteSequence|DateTimeInterface|Stringable|string|int|float|bool ...$members): static
     {
         return new self(Parameters::create(), $members);
     }

src/InnerListTest.php

@@ -30,7 +30,7 @@ public function it_can_add_or_remove_members(): void
     {
         $stringItem = Item::from('helloWorld');
         $booleanItem = Item::from(true);
-        $instance = InnerList::fromMembers($stringItem, $booleanItem);
+        $instance = InnerList::from($stringItem, $booleanItem);
 
         self::assertCount(2, $instance);
         self::assertTrue($instance->has(1));
@@ -60,7 +60,7 @@ public function it_can_add_or_remove_members(): void
     #[Test]
     public function it_can_unshift_insert_and_replace(): void
     {
-        $container = InnerList::fromMembers()
+        $container = InnerList::from()
             ->unshift('42')
             ->push(42)
             ->insert(1, 42.0)
@@ -75,7 +75,7 @@ public function it_can_unshift_insert_and_replace(): void
     #[Test]
     public function it_returns_the_same_object_if_nothing_is_changed(): void
     {
-        $container = InnerList::fromMembers(42, 'forty-two');
+        $container = InnerList::from(42, 'forty-two');
 
         $sameContainer = $container
             ->unshift()
@@ -90,21 +90,21 @@ public function it_fails_to_replace_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        InnerList::fromMembers()->replace(0, ByteSequence::fromDecoded('Hello World'));
+        InnerList::from()->replace(0, ByteSequence::fromDecoded('Hello World'));
     }
 
     #[Test]
     public function it_fails_to_insert_at_an_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        InnerList::fromMembers()->insert(3, ByteSequence::fromDecoded('Hello World'));
+        InnerList::from()->insert(3, ByteSequence::fromDecoded('Hello World'));
     }
 
     #[Test]
     public function it_fails_to_return_an_member_with_invalid_index(): void
     {
-        $instance = InnerList::fromMembers();
+        $instance = InnerList::from();
 
         self::assertFalse($instance->has(3));
 
@@ -127,7 +127,7 @@ public function it_fails_to_access_unknown_parameter_values(): void
     {
         $this->expectException(StructuredFieldError::class);
 
-        InnerList::fromMembers(false)->parameters()->get('bar')->value();
+        InnerList::from(false)->parameters()->get('bar')->value();
     }
 
     #[Test]
@@ -158,29 +158,29 @@ public function it_fails_to_insert_unknown_index_via_the_array_access_interface(
     {
         $this->expectException(StructuredFieldError::class);
 
-        InnerList::fromMembers()->insert(0, Item::from(42.0));
+        InnerList::from()->insert(0, Item::from(42.0));
     }
 
     #[Test]
     public function it_returns_the_same_object_if_no_member_is_removed(): void
     {
-        self::assertCount(0, InnerList::fromMembers()->remove(0));
+        self::assertCount(0, InnerList::from()->remove(0));
     }
 
     #[Test]
     public function it_fails_to_fetch_an_value_using_an_integer(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        InnerList::fromMembers()->get('zero');
+        InnerList::from()->get('zero');
     }
 
     #[Test]
     public function it_can_access_the_item_value(): void
     {
         $token = Token::fromString('token');
         $input = ['foobar', 0, false, $token];
-        $structuredField = InnerList::fromMembers(...$input);
+        $structuredField = InnerList::from(...$input);
 
         self::assertFalse($structuredField->get(2)->value());
         self::assertEquals($token, $structuredField->get(-1)->value());
@@ -223,7 +223,7 @@ public function it_can_create_via_parameters_access_methods_a_new_object(): void
     #[Test]
     public function it_implements_the_array_access_interface(): void
     {
-        $structuredField = InnerList::fromMembers('foobar', 'foobar', 'zero', 0);
+        $structuredField = InnerList::from('foobar', 'foobar', 'zero', 0);
 
         self::assertInstanceOf(Item::class, $structuredField->get(0));
         self::assertInstanceOf(Item::class, $structuredField[0]);
@@ -236,22 +236,22 @@ public function it_forbids_removing_members_using_the_array_access_interface():
     {
         $this->expectException(LogicException::class);
 
-        unset(InnerList::fromMembers('foobar', 'foobar', 'zero', 0)[0]);
+        unset(InnerList::from('foobar', 'foobar', 'zero', 0)[0]);
     }
 
     #[Test]
     public function it_forbids_adding_members_using_the_array_access_interface(): void
     {
         $this->expectException(LogicException::class);
 
-        InnerList::fromMembers('foobar', 'foobar', 'zero', 0)[0] = Item::from(false);
+        InnerList::from('foobar', 'foobar', 'zero', 0)[0] = Item::from(false);
     }
 
 
     #[Test]
     public function it_can_returns_the_container_member_keys(): void
     {
-        $instance = InnerList::fromMembers();
+        $instance = InnerList::from();
 
         self::assertSame([], $instance->keys());
 
@@ -260,7 +260,7 @@ public function it_can_returns_the_container_member_keys(): void
 
         self::assertSame([0, 1], $newInstance->keys());
 
-        $container = InnerList::fromMembers()
+        $container = InnerList::from()
             ->unshift('42')
             ->push(42)
             ->insert(1, 42.0)

src/ItemTest.php

@@ -315,16 +315,16 @@ public function it_can_create_an_item_from_a_array_of_pairs(): void
         self::assertEquals($instance3, $instance1);
     }
 
+    #[Test]
+    #[DataProvider('invalidPairProvider')]
     /**
      * @param array<mixed> $pair
      */
-    #[Test]
-    #[DataProvider('invalidPairProvider')]
     public function it_fails_to_create_an_item_from_an_array_of_pairs(array $pair): void
     {
         $this->expectException(SyntaxError::class);
 
-        Item::fromPair($pair);  /* @phpstan-ignore-line */
+        Item::fromPair($pair);  // @phpstan-ignore-line
     }
 
     /**

src/OuterList.php

@@ -45,15 +45,15 @@ private static function filterMember(iterable|StructuredField|Token|ByteSequence
         return match (true) {
             ($member instanceof MemberList && $member instanceof ParameterAccess),
             $member instanceof Value => $member,
-            is_iterable($member) => InnerList::fromMembers(...$member),
+            is_iterable($member) => InnerList::from(...$member),
             default => Item::from($member),
         };
     }
 
     /**
      * @param StructuredField|iterable<Value|DataType>|DataType ...$members
      */
-    public static function fromMembers(iterable|StructuredField|Token|ByteSequence|DateTimeInterface|Stringable|string|int|float|bool ...$members): self
+    public static function from(iterable|StructuredField|Token|ByteSequence|DateTimeInterface|Stringable|string|int|float|bool ...$members): self
     {
         return new self(...$members);
     }
@@ -65,7 +65,7 @@ public static function fromMembers(iterable|StructuredField|Token|ByteSequence|D
      */
     public static function fromHttpValue(Stringable|string $httpValue): self
     {
-        return self::fromMembers(...array_map(
+        return self::from(...array_map(
             fn (mixed $value) => is_array($value) ? InnerList::fromAssociativeParameters($value[1], ...$value[0]) : $value,
             Parser::parseList($httpValue)
         ));