bugfix OrderedList::toHttpValue method

Author: nyamsprod

src/OrderedList.php

@@ -12,7 +12,6 @@
 use function array_values;
 use function count;
 use function implode;
-use function is_int;
 
 /**
  * @implements IteratorAggregate<array-key, Item|InnerList>
@@ -60,15 +59,7 @@ public static function fromHttpValue(string $httpValue): self
 
     public function toHttpValue(): string
     {
-        $returnValue = [];
-        foreach ($this->members as $key => $member) {
-            $returnValue[] = match (true) {
-                $member instanceof Item && true === $member->value() => $key.$member->parameters()->toHttpValue(),
-                default => !is_int($key) ? $key.'='.$member->toHttpValue() : $member->toHttpValue(),
-            };
-        }
-
-        return implode(', ', $returnValue);
+        return implode(', ', array_map(fn (InnerList|Item $member): string => $member->toHttpValue(), $this->members));
     }
 
     public function count(): int

src/OrderedListTest.php

@@ -169,4 +169,21 @@ public function it_can_be_regenerated_with_eval(): void
 
         self::assertEquals($instance, $generatedInstance);
     }
+
+    /**
+     * @test
+     */
+    public function test_it_can_generate_the_same_value(): void
+    {
+        $res = OrderedList::fromHttpValue('token, "string", ?1; parameter, (42 42.0)');
+
+        $list = OrderedList::fromMembers([
+            new Token('token'),
+            'string',
+            Item::from(true, ['parameter' => true]),
+            InnerList::fromMembers([42, 42.0]),
+        ]);
+
+        self::assertSame($res->toHttpValue(), $list->toHttpValue());
+    }
 }