Skip to content

Commit 30352b5

Browse files
Wizard1209claude
andcommitted
Trim stale status comments in tz5 pubkey tests
Drop the now-false "RED until the fix lands" / "currently stop at BLpk" status notes from the tz5/mdpk forging tests (the fix has landed; they are green). Keep the evergreen "why" (reveals embed an mdpk pubkey forged via forge_public_key, tag \x04). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 14e0d06 commit 30352b5

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

tests/unit_tests/test_michelson/test_forge_address.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,8 @@ def test_forge_unforge_tz5_key_hash_only(self):
2929

3030

3131
class TestForgePublicKey:
32-
# GAP-1: tz5 / ML-DSA-44 reveals embed an `mdpk` public key, which is forged
33-
# by forge_public_key (NOT forge_address). These currently stop at BLpk (tag
34-
# \x03) and raise — RED until the forge_public_key/unforge_public_key fix
35-
# (add `mdpk` -> tag \x04) lands.
32+
# tz5 / ML-DSA-44 reveals embed an `mdpk` public key, forged by
33+
# forge_public_key (tag \x04) — a path distinct from forge_address.
3634
def test_forge_unforge_tz5_mdpk_round_trip(self):
3735
# synthetic ML-DSA-44 public key: exactly 1312 bytes of mdpk payload
3836
payload = bytes(range(256)) * 5 + bytes(32)

tests/unit_tests/test_operation/test_forging.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,8 @@ def test_operation_hash_is_correct(self, opg_hash):
3535
self.assertEqual(opg_hash, res)
3636

3737
def test_forge_reveal_with_tz5_account(self):
38-
# GAP-1: a tz5 reveal embeds an ML-DSA-44 (mdpk) public key, so
39-
# forge_reveal -> forge_public_key must handle it. RED until the
40-
# forge_public_key fix (mdpk -> tag \x04) lands.
38+
# a tz5 reveal embeds an ML-DSA-44 (mdpk) public key, so
39+
# forge_reveal -> forge_public_key must tag it \x04.
4140
payload = bytes(range(256)) * 5 + bytes(32)
4241
content = {
4342
'kind': 'reveal',

0 commit comments

Comments
 (0)