Skip to content

Commit 238fe43

Browse files
authored
Merge pull request #152 from bakwc/fixDnsIssue
Fix dns issue
2 parents fd40b73 + 59b132e commit 238fe43

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

pysyncobj/dns_resolver.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ def resolve(self, hostname):
2424
prevIps = ips
2525
ips = self.__doResolve(hostname)
2626
if not ips:
27+
logging.warning("failed to resolve hostname: " + hostname)
2728
ips = prevIps
2829
self.__cache[hostname] = (currTime, ips)
2930
return None if not ips else random.choice(ips)

pysyncobj/node.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def __init__(self, address, **kwargs):
6969
self.__address = address
7070
self.__host, port = address.rsplit(':', 1)
7171
self.__port = int(port)
72-
self.__ip = globalDnsResolver().resolve(self.host)
72+
#self.__ip = globalDnsResolver().resolve(self.host)
7373

7474
@property
7575
def address(self):
@@ -85,7 +85,7 @@ def port(self):
8585

8686
@property
8787
def ip(self):
88-
return self.__ip
88+
return globalDnsResolver().resolve(self.__host)
8989

9090
def __repr__(self):
9191
v = vars(self)

pysyncobj/tcp_connection.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ def setOnDisconnectedCallback(self, onDisconnected):
7171
self.__onDisconnected = onDisconnected
7272

7373
def connect(self, host, port):
74+
if host is None:
75+
return False
7476
self.__state = CONNECTION_STATE.DISCONNECTED
7577
self.__fileno = None
7678
self.__socket = socket.socket(_getAddrType(host), socket.SOCK_STREAM)

0 commit comments

Comments
 (0)