Merge pull request #151 from bakwc/bindAllInterfacesByDefault

Binding all interfaces by default

Author: bakwc

appveyor.yml

@@ -3,11 +3,12 @@ environment:
   matrix:
 
     - PYTHON: "C:\\Python27"
-    - PYTHON: "C:\\Python34"
+#    - PYTHON: "C:\\Python34"
     - PYTHON: "C:\\Python35"
-#    - PYTHON: "C:\\Python36"
+    - PYTHON: "C:\\Python38"
 
 install:
+  - "%PYTHON%\\python.exe -m pip install --upgrade pip"
   - "%PYTHON%\\python.exe -m pip install pytest"
   - "%PYTHON%\\python.exe -m pip install cryptography"
 

pysyncobj/transport.py

@@ -259,11 +259,18 @@ def _createServer(self):
         """
 
         conf = self._syncObj.conf
-        bindAddr = conf.bindAddress or getattr(self._selfNode, 'address')
-        if not bindAddr:
+        bindAddr = conf.bindAddress
+        seflAddr = getattr(self._selfNode, 'address')
+        if bindAddr is not None:
+            host, port = bindAddr.rsplit(':', 1)
+        elif seflAddr is not None:
+            host, port = seflAddr.rsplit(':', 1)
+            host = '0.0.0.0'
+        else:
             raise RuntimeError('Unable to determine bind address')
-        host, port = bindAddr.rsplit(':', 1)
-        host = globalDnsResolver().resolve(host)
+        
+        if host != '0.0.0.0':
+            host = globalDnsResolver().resolve(host)
         self._server = TcpServer(self._syncObj._poller, host, port, onNewConnection = self._onNewIncomingConnection,
                                  sendBufferSize = conf.sendBufferSize,
                                  recvBufferSize = conf.recvBufferSize,