[fixes #6979] Fix input not normalising to ObjectId for certain query operators#484
Open
Rua-Yuki wants to merge 1 commit into
Open
Conversation
The following operators were affected and did not have suitable input values normalised to ObjectId instances prior: • > • < • >= • <= A tryNormalizeMongoObjectId helper function was added to minimise repetition while implementing this fix.
Collaborator
|
Thanks for submitting this pull request, @Rua-Yuki! We'll look at it ASAP. In the mean time, here are some ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes balderdashy/sails#6979.
All tests appear to be passing locally. Further, these changes don't appear to have caused any problems with our large app/test suites.
I'd like to have tests added to validate this behaviour and prevent any sort of regression; would balderdashy/waterline-adapter-tests be the correct place to have this done, or should we create only adapter-specific tests here?