Skip to content

Fix GL pixel shader debug failure with gl_FrontFacing #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fengT-T wants to merge 1 commit into from
+3 −3
Closed

Fix GL pixel shader debug failure with gl_FrontFacing #3855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions renderdoc/driver/gl/gl_shaderdebug.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2165,8 +2165,8 @@ precision highp float;
#extension GL_KHR_shader_subgroup_quad : require
#endif

// bool signature elements get reflected as ints, make macros for their access to cast to int
#define gl_FrontFacing (gl_FrontFacing ? 1u : 0u)
// bool-to-uint conversion is explicit at each use site; no macro to avoid
// contaminating the user's shader code (gl_FrontFacing must remain bool)
#define gl_HelperInvocation (gl_HelperInvocation ? 1u : 0u)

)EOSHADER";
Expand Down Expand Up @@ -2522,7 +2522,7 @@ void main()
rd_sample = gl_SampleID;
#endif

isFrontFace = gl_FrontFacing;
isFrontFace = gl_FrontFacing ? 1u : 0u;

#endif

Expand Down
Loading