patch: migrate to prebuilidify + flowzone + upgrade all deps#83
patch: migrate to prebuilidify + flowzone + upgrade all deps#83aethernet wants to merge 4 commits into
Conversation
aethernet
force-pushed
the
aethernet/flowzone
branch
from
2f769cc to
8de088f
Compare
| ## Support | ||
|
|
||
| If you're having any problem, please [raise an issue][newissue] on GitHub and | ||
| the Resin.io team will be happy to help. |
There was a problem hiding this comment.
Might be worth updating this to say Balena instead of Resin.io 😆
There was a problem hiding this comment.
will do in another PR
| - Issue Tracker: [github.com/resin-io-modules/mountutils/issues][issues] | ||
| - Source Code: [github.com/resin-io-modules/mountutils][source] |
There was a problem hiding this comment.
And I guess these URLs need updating too!
|
I removed the Resin CI required checks -- should be good for merging. |
aethernet
force-pushed
the
aethernet/flowzone
branch
from
8393a3e to
a2aa310
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| branches: [main, master] | ||
|
|
||
| jobs: | ||
| flowzone: |
There was a problem hiding this comment.
I'm guessing this needs some changes to continue testing on mac/windows, cc @klutchell ?
There was a problem hiding this comment.
@Page- Flowzone still doesn't support npm tests on macos or windows, it hasn't really been a priority. It needs to be done via custom actions like we did here:
https://github.com/balena-io-modules/winusb-driver-generator/blob/master/.github/workflows/flowzone.yml
https://github.com/balena-io-modules/winusb-driver-generator/blob/master/.github/actions/test/action.yml
I would like to add multiple OS support to npm checks in Flowzone, but it complicates our testing matrix quite a bit and I don't want to slow down the pre-checks. We can open a research/project if it's worth looking into further.
| "configure": "node-gyp configure", | ||
| "build": "node-gyp build", | ||
| "build": "node-gyp-build && npm run prebuildify", | ||
| "prebuildify": "prebuildify -t 18.18.2 -t 20.5.1 --strip", |
There was a problem hiding this comment.
What was the reason for moving away from --all? Since the specific targets are likely to rapidly become redundant for actual usage
| "nan": "^2.14.0", | ||
| "prebuild-install": "^4.0.0" | ||
| "node-gyp-build": "^4.7.1", | ||
| "prebuildify": "^5.0.1" |
| "test": "mocha tests -R spec", | ||
| "install": "prebuild-install || node-gyp rebuild", | ||
| "prebuild-release": "prebuild --all --strip" | ||
| "install": "node-gyp-build" |
There was a problem hiding this comment.
I'm not sure about that one. I took it straight out of the prebuildify documentation. What would be the benefit of a using a prepare script instead?
aethernet
force-pushed
the
aethernet/flowzone
branch
3 times, most recently
from
0b81122 to
27505a6
Compare
aethernet
force-pushed
the
aethernet/flowzone
branch
from
27505a6 to
4bad804
Compare
6 participants
switch from
prebuildtoprebuildifyswitch from travisci + appveyor to flowzone
upgrade deps