Merge pull request #65 from balena-io/node12

update interface for node 12 interface changes

Author: zvin

.travis.yml

@@ -8,7 +8,7 @@ node_js:
   - "6"
   - "8"
   - "10"
-  - "11"
+  - "12"
 
 addons:
   apt:

appveyor.yml

@@ -12,12 +12,16 @@ cache:
 
 environment:
   matrix:
+    - nodejs_version: 12
     - nodejs_version: 10
     - nodejs_version: 8
     - nodejs_version: 6
 
+platform:
+  - x64
+
 install:
-  - ps: Install-Product node $env:nodejs_version x64
+  - ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:PLATFORM
   - choco install mingw
   - npm install -g --production windows-build-tools@^3.1.0
   # Unlike travis, appveyor doesn't clone --recursive, so we have to:

package.json

@@ -24,7 +24,7 @@
     "async": "^2.6.1",
     "bluebird": "^3.5.3",
     "bindings": "^1.3.0",
-    "nan": "2.11.1",
+    "nan": "2.13.2",
     "prebuild-install": "^5.2.1"
   },
   "devDependencies": {

src/async.cc

@@ -29,7 +29,7 @@ void init_async() {
 	uv_async_init(uv_default_loop(), async, default_loop_entry);
 	uv_mutex_init(&lock);
 	if (!persistent_callback_initialized) {
-		persistent_callback.Reset(New<v8::FunctionTemplate>(callback_wrapper)->GetFunction());
+		persistent_callback.Reset(Nan::GetFunction(Nan::New<v8::FunctionTemplate>(callback_wrapper)).ToLocalChecked());
 		persistent_callback_initialized = true;
 	}
 }

src/js_io.cc

@@ -23,7 +23,7 @@ static void js_request_done(v8::Local<v8::Value> ret, void* _s) {
 	if (ret->IsNull()) {
 		s->ret = 0;
 	} else {
-		s->ret = static_cast<errcode_t>(ret->IntegerValue());
+		s->ret = static_cast<errcode_t>(Nan::To<int64_t>(ret).FromJust());
 	}
 
 	uv_sem_post(&s->js_sem);

src/node_ext2fs.cc

@@ -39,18 +39,20 @@ extern "C" {
 
 ext2_filsys get_filesystem(NAN_METHOD_ARGS_TYPE info) {
 	return static_cast<ext2_filsys>(
-		info[0]->ToObject().As<v8::External>()->Value()
+		Nan::To<v8::Object>(info[0]).ToLocalChecked().As<v8::External>()->Value()
 	);
 }
 
 ext2_file_t get_file(NAN_METHOD_ARGS_TYPE info) {
 	return static_cast<ext2_file_t>(
-		info[0]->ToObject().As<v8::External>()->Value()
+		Nan::To<v8::Object>(info[0]).ToLocalChecked().As<v8::External>()->Value()
 	);
 }
 
 unsigned int get_flags(NAN_METHOD_ARGS_TYPE info) {
-	return static_cast<unsigned int>(info[1]->IntegerValue());
+	return static_cast<unsigned int>(
+		Nan::To<int64_t>(info[1]).FromJust()
+	);
 }
 
 std::string get_path(NAN_METHOD_ARGS_TYPE info) {
@@ -306,8 +308,8 @@ class OpenWorker : public AsyncWorker {
 		: AsyncWorker(callback) {
 			fs = get_filesystem(info);
 			path = get_path(info);
-			flags = static_cast<unsigned int>(info[2]->IntegerValue());
-			mode = static_cast<unsigned int>(info[3]->IntegerValue());
+			flags = static_cast<unsigned int>(Nan::To<int64_t>(info[2]).FromJust());
+			mode = static_cast<unsigned int>(Nan::To<int64_t>(info[3]).FromJust());
 		}
 
 		void Execute () {
@@ -440,9 +442,9 @@ class ReadWorker : public AsyncWorker {
 			file = get_file(info);
 			flags = get_flags(info);
 			buffer = (char*) node::Buffer::Data(info[2]);
-			offset = static_cast<unsigned long long>(info[3]->IntegerValue());  // buffer offset
-			length = static_cast<unsigned int>(info[4]->IntegerValue());
-			position = static_cast<unsigned long long>(info[5]->IntegerValue());  // file offset
+			offset = static_cast<unsigned long long>(Nan::To<int64_t>(info[3]).FromJust());  // buffer offset
+			length = static_cast<unsigned int>(Nan::To<int64_t>(info[4]).FromJust());
+			position = static_cast<unsigned long long>(Nan::To<int64_t>(info[5]).FromJust());  // file offset
 		}
 
 		void Execute () {
@@ -491,9 +493,9 @@ class WriteWorker : public AsyncWorker {
 			file = get_file(info);
 			flags = get_flags(info);
 			buffer = static_cast<char*>(node::Buffer::Data(info[2]));
-			offset = static_cast<unsigned long long>(info[3]->IntegerValue());  // buffer offset
-			length = static_cast<unsigned int>(info[4]->IntegerValue());
-			position = static_cast<unsigned long long>(info[5]->IntegerValue());  // file offset
+			offset = static_cast<unsigned long long>(Nan::To<int64_t>(info[3]).FromJust());  // buffer offset
+			length = static_cast<unsigned int>(Nan::To<int64_t>(info[4]).FromJust());
+			position = static_cast<unsigned long long>(Nan::To<int64_t>(info[5]).FromJust());  // file offset
 		}
 
 		void Execute () {
@@ -544,7 +546,7 @@ class ChModWorker : public AsyncWorker {
 		: AsyncWorker(callback) {
 			file = get_file(info);
 			flags = get_flags(info);
-			mode = static_cast<unsigned int>(info[2]->IntegerValue());
+			mode = static_cast<unsigned int>(Nan::To<int64_t>(info[2]).FromJust());
 		}
 
 		void Execute () {
@@ -582,8 +584,8 @@ class ChOwnWorker : public AsyncWorker {
 		: AsyncWorker(callback) {
 			file = get_file(info);
 			flags = get_flags(info);
-			uid = static_cast<unsigned int>(info[2]->IntegerValue());
-			gid = static_cast<unsigned int>(info[3]->IntegerValue());
+			uid = static_cast<unsigned int>(Nan::To<int64_t>(info[2]).FromJust());
+			gid = static_cast<unsigned int>(Nan::To<int64_t>(info[3]).FromJust());
 		}
 
 		void Execute () {
@@ -772,7 +774,7 @@ class MkDirWorker : public AsyncWorker {
 		: AsyncWorker(callback) {
 			fs = get_filesystem(info);
 			path = get_path(info);
-			mode = static_cast<unsigned int>(info[2]->IntegerValue());
+			mode = static_cast<unsigned int>(Nan::To<int64_t>(info[2]).FromJust());
 		}
 
 		void Execute () {