Merge pull request #108 from balena-io-modules/remove-lodash

Tests: remove lodash

Author: Page-

package.json

@@ -18,12 +18,10 @@
   "devDependencies": {
     "@balena/lint": "^9.2.1",
     "@types/chai": "^4.3.20",
-    "@types/lodash": "^4.17.10",
     "@types/mocha": "^10.0.8",
     "chai": "^4.5.0",
     "husky": "^9.1.6",
     "lint-staged": "^16.0.0",
-    "lodash": "^4.17.21",
     "mocha": "^11.0.0",
     "peggy": "^5.0.0",
     "ts-node": "^10.9.2",

test/filterby.ts

@@ -1,6 +1,5 @@
 import * as assert from 'assert';
 import { expect } from 'chai';
-import * as _ from 'lodash';
 import type { ExpectationFn, TestFn } from './test';
 
 type Duration = {
@@ -19,7 +18,7 @@ export default function (test: TestFn) {
 			value: typeof odataValue | Duration = odataValue,
 		) {
 			const binds: Array<string | number | boolean> = [];
-			if (value != null && !_.isObject(value)) {
+			if (value != null && typeof value !== 'object') {
 				binds.push(value);
 			}
 			test(`$filter=Foo ${op} ${odataValue}`, binds, function (result) {
@@ -35,7 +34,7 @@ export default function (test: TestFn) {
 						.to.have.property('name')
 						.that.equals('Foo'));
 
-				if (odataValue === null || _.isObject(value)) {
+				if (odataValue === null || typeof value === 'object') {
 					it(`rhr should be ${value}`, () => {
 						expect(result.options.$filter[2]).to.deep.equal(value);
 					});
@@ -56,7 +55,7 @@ export default function (test: TestFn) {
 					expect(result.options.$filter[0]).to.equal(op);
 				});
 
-				if (odataValue === null || _.isObject(value)) {
+				if (odataValue === null || typeof value === 'object') {
 					it(`lhr should be ${value}`, () =>
 						expect(result.options.$filter[1]).to.deep.equal(value));
 				} else {

test/stress.ts

@@ -1,9 +1,8 @@
 import test from './test';
 import * as assert from 'assert';
-import * as _ from 'lodash';
 
 describe('Stress Testing', function () {
-	const ids = _.range(1, 2000);
+	const ids = Array.from({ length: 1999 }, (_, i) => i + 1);
 	const filterString = ids.map((i) => 'id eq ' + i).join(' or ');
 	test('$filter=' + filterString, ids, (result) => {
 		it('A filter should be present', () => {

test/test.ts

@@ -1,14 +1,13 @@
 import * as ODataParser from '../odata-parser';
 import { expect } from 'chai';
-import * as _ from 'lodash';
 
 type BindPrimitive = number | string | boolean | object;
 const getBindType = function (value: BindPrimitive) {
-	if (_.isNumber(value)) {
+	if (typeof value === 'number') {
 		return ['Real', value];
-	} else if (_.isString(value)) {
+	} else if (typeof value === 'string') {
 		return ['Text', value];
-	} else if (_.isBoolean(value)) {
+	} else if (typeof value === 'boolean') {
 		return ['Boolean', value];
 	} else {
 		return value;
@@ -61,11 +60,11 @@ function raw(
 	const expectation = optArgs.pop() as ExpectationFn;
 	const [binds = [], options = { startRule: 'Process' }, params = {}] =
 		optArgs as any as [binds?: Binds, opts?: Opts, params?: Params];
-	const processedBinds = _.map(binds, getBindType) as Binds &
+	const processedBinds = binds.map(getBindType) as Binds &
 		Record<string, BindPrimitive>;
-	_.each(params, (value, key) => {
+	for (const [key, value] of Object.entries(params)) {
 		processedBinds[key] = getBindType(value);
-	});
+	}
 	describe(`Parsing ${input}`, function () {
 		let result;
 		try {