Skip to content

Commit c5f5e41

Browse files
committed
fix: pin Windows CI jobs to windows-2022 (VS 2022)
windows-latest now resolves to the windows-2025-vs2026 image (Visual Studio 2026 / v18 only), so the hardcoded `cmake -G "Visual Studio 17 2022"` fails at configure on every PR. Pin the Windows jobs to windows-2022, which provides VS 2022 17.14 and matches the ..._vs2022.zip deps cache from build_deps.yml. Stop-gap until VS 2026 support lands. Non-Windows CI fixes were split out to #11277.
1 parent 5875ec2 commit c5f5e41

5 files changed

Lines changed: 19 additions & 19 deletions

File tree

.github/workflows/build_all.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
include:
4646
- os: ubuntu-22.04
4747
- os: ubuntu-24.04
48-
- os: windows-latest
48+
- os: windows-2022
4949
- os: macos-15-intel
5050
arch: x86_64
5151
- os: macos-15

.github/workflows/build_bambu.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
fail-on-cache-miss: true
3838

3939
- name: Get the version and date on Ubuntu and macOS
40-
if: inputs.os != 'windows-latest'
40+
if: inputs.os != 'windows-2022'
4141
run: |
4242
ver_pure=$(grep 'set(SLIC3R_VERSION' version.inc | cut -d '"' -f2)
4343
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
@@ -51,7 +51,7 @@ jobs:
5151
shell: bash
5252

5353
- name: Get the version and date on Windows
54-
if: inputs.os == 'windows-latest'
54+
if: inputs.os == 'windows-2022'
5555
run: |
5656
$date = Get-Date -Format 'yyyyMMdd'
5757
$ref = "${{ github.ref }}"
@@ -114,18 +114,18 @@ jobs:
114114

115115
# Windows
116116
- name: setup MSVC
117-
if: inputs.os == 'windows-latest'
117+
if: inputs.os == 'windows-2022'
118118
uses: microsoft/setup-msbuild@v2
119119

120120
- name: Install nsis and pkgconfig
121-
if: inputs.os == 'windows-latest'
121+
if: inputs.os == 'windows-2022'
122122
run: |
123123
dir "C:/Program Files (x86)/Windows Kits/10/Include"
124124
choco install nsis
125125
choco install pkgconfiglite
126126
127127
- name: Build slicer Win
128-
if: inputs.os == 'windows-latest'
128+
if: inputs.os == 'windows-2022'
129129
working-directory: ${{ github.workspace }}
130130
run: |
131131
mkdir build
@@ -134,25 +134,25 @@ jobs:
134134
cmake --build . --target install --config Release -- -m
135135
136136
# - name: Create installer Win
137-
# if: inputs.os == 'windows-latest'
137+
# if: inputs.os == 'windows-2022'
138138
# working-directory: ${{ github.workspace }}/build
139139
# run: |
140140
# cpack -G NSIS
141141

142142
- name: Pack app
143-
if: inputs.os == 'windows-latest'
143+
if: inputs.os == 'windows-2022'
144144
working-directory: ${{ github.workspace }}
145145
shell: cmd
146146
run: '"C:/Program Files/7-Zip/7z.exe" a -tzip BambuStudio_Windows_${{ env.ver }}_portable.zip ${{ github.workspace }}/install-dir'
147147

148148
# - name: Pack PDB
149-
# if: inputs.os == 'windows-latest'
149+
# if: inputs.os == 'windows-2022'
150150
# working-directory: ${{ github.workspace }}/build/src/Release
151151
# shell: cmd
152152
# run: '"C:/Program Files/7-Zip/7z.exe" a -m0=lzma2 -mx9 Debug_PDB_${{ env.ver }}_for_developers_only.7z *.pdb'
153153

154154
- name: Upload artifacts Win zip
155-
if: inputs.os == 'windows-latest'
155+
if: inputs.os == 'windows-2022'
156156
uses: actions/upload-artifact@v6
157157
with:
158158
name: BambuStudio_Windows_${{ env.ver }}_portable

.github/workflows/build_check_cache.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ jobs:
3030
- name: set outputs
3131
id: set_outputs
3232
env:
33-
dep-folder-name: ${{ inputs.os == 'windows-latest' && '/BambuStudio_dep' || ((inputs.os == 'macos-15-intel' || inputs.os == 'macos-15') && '') || (inputs.os != 'macos-15-intel' && inputs.os != 'macos-15') && '/destdir' || '' }}
34-
output-cmd: ${{ inputs.os == 'windows-latest' && '$env:GITHUB_OUTPUT' || '"$GITHUB_OUTPUT"'}}
33+
dep-folder-name: ${{ inputs.os == 'windows-2022' && '/BambuStudio_dep' || ((inputs.os == 'macos-15-intel' || inputs.os == 'macos-15') && '') || (inputs.os != 'macos-15-intel' && inputs.os != 'macos-15') && '/destdir' || '' }}
34+
output-cmd: ${{ inputs.os == 'windows-2022' && '$env:GITHUB_OUTPUT' || '"$GITHUB_OUTPUT"'}}
3535
run: |
3636
echo cache-key=${{ inputs.os }}-cache-bambustudio_deps-build-${{ hashFiles('deps/**') }} >> ${{ env.output-cmd }}
3737
echo cache-path=${{ github.workspace }}/deps/build${{ env.dep-folder-name }} >> ${{ env.output-cmd }}

.github/workflows/build_deps.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,23 +42,23 @@ jobs:
4242
key: ${{ inputs.cache-key }}
4343

4444
- name: setup dev on Windows
45-
if: inputs.os == 'windows-latest'
45+
if: inputs.os == 'windows-2022'
4646
uses: microsoft/setup-msbuild@v2
4747

4848
- name: Get the date on Ubuntu and macOS
49-
if: inputs.os != 'windows-latest'
49+
if: inputs.os != 'windows-2022'
5050
run: echo "date=$(date +'%Y%m%d')" >> $GITHUB_ENV
5151
shell: bash
5252

5353
- name: Get the date on Windows
54-
if: inputs.os == 'windows-latest'
54+
if: inputs.os == 'windows-2022'
5555
run: echo "date=$(Get-Date -Format 'yyyyMMdd')" | Out-File -Append -FilePath $env:GITHUB_ENV -Encoding utf8
5656
shell: pwsh
5757

5858

5959
# Build Dependencies
6060
- name: Build on Windows
61-
if: inputs.os == 'windows-latest'
61+
if: inputs.os == 'windows-2022'
6262
working-directory: ${{ github.workspace }}
6363
run: |
6464
choco install strawberryperl
@@ -70,7 +70,7 @@ jobs:
7070
msbuild /m ALL_BUILD.vcxproj
7171
7272
- name: pack deps on Windows
73-
if: inputs.os == 'windows-latest'
73+
if: inputs.os == 'windows-2022'
7474
working-directory: ${{ github.workspace }}
7575
run: Compress-Archive -Path "${{ github.workspace }}\deps\build\BambuStudio_dep\*" -DestinationPath "${{ github.workspace }}\deps\build\BambuStudio_dep_win64_${{ env.date }}_vs2022.zip"
7676
shell: pwsh
@@ -161,7 +161,7 @@ jobs:
161161
run: rm -rf ${{ github.workspace }}/deps/build/BambuStudio_dep_mac_${{ inputs.arch }}*.tar.gz
162162

163163
- name: Upload Windows artifacts
164-
if: inputs.os == 'windows-latest'
164+
if: inputs.os == 'windows-2022'
165165
uses: actions/upload-artifact@v6
166166
with:
167167
name: BambuStudio_dep_win64_${{ env.date }}

.github/workflows/winget_updater.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
types: [ released ]
55
jobs:
66
publish:
7-
runs-on: windows-latest
7+
runs-on: windows-2022
88
steps:
99
- uses: vedantmgoyal9/winget-releaser@main
1010
with:

0 commit comments

Comments
 (0)