fix: correct punctuation and grammar in UI warning/tip strings#10813
Open
BenJule wants to merge 6 commits into
Open
fix: correct punctuation and grammar in UI warning/tip strings#10813BenJule wants to merge 6 commits into
BenJule wants to merge 6 commits into
Conversation
BenJule
force-pushed
the
fix/punctuation-spacing-ui-strings
branch
from
7b152ba to
1b2215e
Compare
The upstream build_all.yml only listed 'main' as a push trigger. BenJule/BambuStudio uses 'master' as its default branch, so CI never fired on fork-local pushes. Adding 'master' alongside 'main' makes the full multi-platform build run when master is updated.
… locale files The fila_manager web page was hardcoded in Chinese (lang="zh") with no internationalization support. This commit adds a lightweight i18n system: - Add locales/en.json and locales/zh_CN.json with all UI strings - Add t(key) / tf(key, n) translation helpers loaded at startup - Apply translations via data-i18n / data-i18n-placeholder attributes in HTML - Replace all hardcoded Chinese strings in index.js with t() calls - Language is resolved from the ?lang= URL parameter passed by C++
… strings Two printer status strings shown during calibration used the misspelling "percision" instead of "precision". Also fix lang="zh-CN" in NozzleListTable.html (the table content is set by C++ at runtime). All .po and .pot msgid entries updated to match the corrected source strings.
- 'Problem occured' → 'Problem occurred' (MediaPlayCtrl.cpp) - 'When enable spiral vase mode' → 'When enabling ...' (SelectMachine.cpp, SyncAmsInfoDialog.cpp) - 'connectors is out of object' → 'connectors are out of object' (GLGizmoAdvancedCut.cpp) - 'Error:Detecting ...' → 'Error: Detecting ...' with spacing fixes (GLGizmoText.cpp) Update all corresponding msgid entries in BambuStudio.pot and all 18 .po locale files.
Fix missing spaces after 'Warning:', 'Error:', and 'Tip:' prefixes, missing spaces after sentence-ending periods and commas, and several grammar issues in strings that appear to originate from machine translation: - GLGizmoText.cpp: fix 9 Warning: strings (space + grammar) - 'Warning:create text fail.' → 'Warning: Text creation failed.' - 'Warning:text normal is error.' → 'Warning: Text normal has an error.' - 'Warning:Due to font upgrades,previous...' → proper spacing - 'reedit it will ok' → 'reedit it to fix the issue' - 'dragging text' → 'drag the text' (imperative form) - GLGizmoMeasure.cpp: fix 3 Warning: strings + 'two different mesh' → 'meshes' - GLGizmoSVG.cpp: fix 'Tip:If...' + missing comma + 'svg file' → 'SVG file' - PlaterWorker.hpp: 'error occured' → 'error occurred' - DeviceManager.cpp: missing spaces after period/comma + '(PLA...)' spacing - BindDialog.cpp: 'device.Before', 'termsand', 'Use(collectively)' spacing - ConfigManipulation.cpp: missing spaces after comma and period - AMSSetting.cpp: missing space after '1 minute.' - Preferences.cpp: 'tab.If change value' → 'tab. If you change this value' Update all msgid entries in BambuStudio.pot and all 18 .po locale files.
BenJule
force-pushed
the
fix/punctuation-spacing-ui-strings
branch
from
1b2215e to
952926e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes missing spaces after
Warning:,Error:, andTip:prefixes, missing spaces after sentence-ending periods and commas, and several grammar errors in UI strings that appear to originate from machine translation.Files changed
GLGizmoText.cppWarning:X→Warning: X;create text fail→Text creation failed;text normal is error→Text normal has an error;reedit it will ok→reedit it to fix the issue;dragging text→drag the text; missing comma spacesGLGizmoMeasure.cppWarning:X→Warning: X;two different mesh→two different meshesGLGizmoSVG.cppTip:If...→Tip: If...; missing comma;svg file→SVG filePlaterWorker.hpperror occured→error occurredDeviceManager.cppfilament(PLA...)→filament (PLA...); missing spaces after.and,BindDialog.cppdevice.Before→device. Before;termsand→terms and;Use(collectively)→Use (collectively)ConfigManipulation.cpp,and.in chamber temperature warningAMSSetting.cpp1 minute.The→1 minute. ThePreferences.cpptab.If change value→tab. If you change this valueAll corresponding
msgidentries inBambuStudio.potand all 18 language.pofiles have been updated.Test plan
Tip:message has correct spacingoccurredspellingAlways show shells in previewtooltip — confirm corrected wordingCloses #10853.