Skip to content

feat(gui): auto-save the open project every 5 minutes#10818

Open
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:feat/autosave-arrowkeys-darkmode-fixes
Open

feat(gui): auto-save the open project every 5 minutes#10818
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:feat/autosave-arrowkeys-darkmode-fixes

Conversation

@BenJule

@BenJule BenJule commented May 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Auto-saves the open project every 5 minutes: a timer silently calls save when the project is dirty and already has a file path, gated behind the autosave_enabled config key.

(Reduced from the original three-feature PR as requested — see split note below.)

Note: there is no Preferences toggle for autosave_enabled yet, so it is off unless the key is set. Happy to add a UI toggle if you'd like.

@BenJule BenJule force-pushed the feat/autosave-arrowkeys-darkmode-fixes branch 2 times, most recently from 22d6300 to eb5a57e Compare May 21, 2026 08:55
@BenJule BenJule closed this Jun 7, 2026
@BenJule BenJule deleted the feat/autosave-arrowkeys-darkmode-fixes branch June 7, 2026 10:09
@BenJule BenJule restored the feat/autosave-arrowkeys-darkmode-fixes branch June 7, 2026 11:38
@BenJule BenJule reopened this Jun 7, 2026
@BenJule

BenJule commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

Apologies — this PR was closed by mistake on 2026-06-07, and that was an error on my side, not a deliberate decision to withdraw the change.

It happened as an unintended side effect of a branch cleanup in my fork: deleting the head branch automatically closed this PR. The contribution still stands. I have restored the branch and reopened the PR. Sorry for the noise and any confusion this caused.

@BenJule BenJule force-pushed the feat/autosave-arrowkeys-darkmode-fixes branch from eb5a57e to 00ea44f Compare June 8, 2026 05:24
@BenJule

BenJule commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Force-pushed: rebased onto current master and reduced this PR to the feature's own source changes. The previous revision had inadvertently carried translation-file (.po/.pot) edits, generated web resources, and unrelated source changes (string fixes belonging to #10811/#10813/#10814) over from the branch base — those are now removed. Heads-up: this feature series shares a few central GUI files (e.g. GUI_App.cpp, MainFrame.cpp, Preferences.hpp), so there is some overlap between my feature PRs.

@tonghao-bbl

Copy link
Copy Markdown
Contributor

Hi @BenJule These are three different features, can you split them into three PR?

@BenJule BenJule force-pushed the feat/autosave-arrowkeys-darkmode-fixes branch from 00ea44f to dbfb51c Compare June 22, 2026 08:07
@BenJule BenJule changed the title feat: auto-save, fine arrow-key steps (0.1/0.01 mm), dark mode contrast fix feat(gui): auto-save the open project every 5 minutes Jun 22, 2026
@BenJule

BenJule commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @tonghao-bbl — split done. This PR is now auto-save only; the other two features are their own PRs:

While splitting I also removed code that had ridden along on this branch from the shared base and actually belongs to other PRs — hex colour input (#10816), dark-mode follow-system (#11241), the cloud-warning dialog (#10839), the title * indicator (#10837) and the MakerWorld full-site option (the now-closed #10838). Each of the three PRs is now a single focused commit on top of master.

@BambulabRobot BambulabRobot requested review from XinZhangBambu and removed request for FiredEgg-bambu, MackBambu and XinZhangBambu June 22, 2026 08:42
@BenJule

BenJule commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @tonghao-bbl - done, this is split now. This PR is narrowed down to just the auto-save feature (the two MainFrame.cpp/.hpp changes). The other two features that used to be bundled here are their own PRs:

So each feature can be reviewed independently now.

Adds a 5-minute timer that silently saves the current project when it is
dirty and already has a file path, gated behind the `autosave_enabled`
config key. Reduced from the original multi-feature PR to this single
feature, as requested in review.
@BenJule BenJule force-pushed the feat/autosave-arrowkeys-darkmode-fixes branch from dbfb51c to c3baa62 Compare July 3, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants