fix: include pre-built device_page/dist in resources to fix empty Filament Manager#10832
Open
BenJule wants to merge 3 commits into
Open
fix: include pre-built device_page/dist in resources to fix empty Filament Manager#10832BenJule wants to merge 3 commits into
BenJule wants to merge 3 commits into
Conversation
This was referenced May 20, 2026
BenJule
force-pushed
the
fix/10799-device-page-dist-missing
branch
from
aaf1e66 to
00c37f1
Compare
The upstream build_all.yml only listed 'main' as a push trigger. BenJule/BambuStudio uses 'master' as its default branch, so CI never fired on fork-local pushes. Adding 'master' alongside 'main' makes the full multi-platform build run when master is updated.
…ament Manager
The `resources/web/device_page/dist/` directory was excluded from the
repository by the `**/dist/` gitignore rule. All other web assets in
`resources/web/` are pre-built static files committed directly to git,
but `device_page/dist/` was only generated at CMake build time and never
packaged into the Linux AppImage or macOS DMG releases.
Add a gitignore exception to track `resources/web/device_page/dist/` and
commit the pre-built assets (index.html, assets/index.{css,js}, img/**).
This mirrors how all other embedded web pages in BambuStudio are shipped.
The CMake `device_page_build` target will still rebuild these files on a
full source build; the committed dist serves as the fallback that release
packages rely on.
Closes bambulab#10799
Closes bambulab#10806
BenJule
force-pushed
the
fix/10799-device-page-dist-missing
branch
from
00c37f1 to
09561d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Filament Manager tab shows a blank white page on macOS (issue #10799) and throws a "file not found" error on Linux AppImage (issue #10806).
Root cause:
resources/web/device_page/dist/is excluded from the repository by the**/dist/gitignore rule. All other embedded web pages in BambuStudio (resources/web/fila_manager/,resources/web/device/,resources/web/login/, etc.) are pre-built static assets committed directly to git. Thedevice_page/dist/was the only exception — it was only generated at CMake build time via thedevice_page_buildcustom target, and was never included in the Linux AppImage or macOS DMG release packages.Fix
.gitignoreexception to trackresources/web/device_page/dist/index.html,assets/index.{css,js},img/**)The CMake
device_page_buildtarget still rebuilds these files on a full source build; the committed dist serves as the reliable fallback that release packages depend on — matching the approach used for every other embedded web page.Test plan
resources/web/device_page/dist/index.htmlpresent in packaged AppImageCloses #10799
Closes #10806