fix: center Edit Filament dialog on parent window#10835
Open
BenJule wants to merge 3 commits into
Open
Conversation
This was referenced May 20, 2026
BenJule
force-pushed
the
fix/10720-edit-filament-wrong-monitor
branch
from
53689ce to
2c64c7e
Compare
The upstream build_all.yml only listed 'main' as a push trigger. BenJule/BambuStudio uses 'master' as its default branch, so CI never fired on fork-local pushes. Adding 'master' alongside 'main' makes the full multi-platform build run when master is updated.
EditFilamentPresetDialog was created with wxDefaultPosition, which caused the OS to place it on the primary monitor even when Bambu Studio was running on a secondary display. Adding CenterOnParent() in the constructor mirrors how every other dialog in the codebase positions itself (e.g. ReleaseNote, KBShortcutsDialog, CaliHistoryDialog). Fixes bambulab#10720
BenJule
force-pushed
the
fix/10720-edit-filament-wrong-monitor
branch
from
2c64c7e to
575f09c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditFilamentPresetDialogwas created withwxDefaultPosition, causing the OS to place it on the primary monitor even when Bambu Studio was running on a secondary display.CenterOnParent()in the constructor mirrors the positioning pattern already used by every other dialog in the codebase (e.g.ReleaseNote,KBShortcutsDialog,CaliHistoryDialog).How to reproduce
Fix
One line: call
this->CenterOnParent()afterFit()in theEditFilamentPresetDialogconstructor so the dialog is always centred over its parent window, regardless of which monitor it is on.Test plan
Fixes #10720