feat: add preference to open full MakerWorld site in Online Models tab#10838
Open
BenJule wants to merge 3 commits into
Open
feat: add preference to open full MakerWorld site in Online Models tab#10838BenJule wants to merge 3 commits into
BenJule wants to merge 3 commits into
Conversation
This was referenced May 20, 2026
BenJule
force-pushed
the
feat/10801-makerworld-full-site
branch
from
ab5e274 to
bf9a11a
Compare
The upstream build_all.yml only listed 'main' as a push trigger. BenJule/BambuStudio uses 'master' as its default branch, so CI never fired on fork-local pushes. Adding 'master' alongside 'main' makes the full multi-platform build run when master is updated.
Preferences > Online Models gains a "Open full MakerWorld site instead of the simplified Studio view" checkbox (config key makerworld_use_full_site). When enabled, the three URL construction paths in WebViewDialog.cpp omit the /studio/webview path segment and map model-detail links to /models/<id>, restoring access to comments, account management, and other full-site features that the restricted webview does not expose. Closes bambulab#10801
BenJule
force-pushed
the
feat/10801-makerworld-full-site
branch
from
bf9a11a to
103773e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preferences → Online Models gains a "Open full MakerWorld site instead of the simplified Studio view" checkbox (config key
makerworld_use_full_site).When enabled, the three URL construction paths in
WebViewDialog.cppomit the/studio/webviewpath segment and map model-detail links to/models/<id>, restoring access to comments, account management, and other full-site features that the restricted webview does not expose.Test plan
/studio/webviewas before.Closes #10801