feat: add 'Don't show this warning again' to cloud connection failure dialog#10839
Open
BenJule wants to merge 3 commits into
Open
feat: add 'Don't show this warning again' to cloud connection failure dialog#10839BenJule wants to merge 3 commits into
BenJule wants to merge 3 commits into
Conversation
This was referenced May 20, 2026
|
Or as a in app notification that appears like a dialog that doesn’t affect click throughs |
Author
|
This clean-up is exactly what the codebase needed after the limitations of the previous patch. Extending the robust focus evaluation down the hierarchy prevents various shortcuts from intercepting key strokes globally when custom layout wrappers have native controls embedded inside. My fix in #10826 tackled the immediate breakdown with the 'Z' key in composite text fields, and having this broader refactoring in #10839 ensures we won't see similar regressions with other shortcuts across different OS platforms. Fully backing this change let's get this merged to finally keep the global hook out of the user's input fields! |
2 tasks
BenJule
force-pushed
the
feat/10589-suppress-cloud-warning
branch
from
98c4600 to
f6da686
Compare
The upstream build_all.yml only listed 'main' as a push trigger. BenJule/BambuStudio uses 'master' as its default branch, so CI never fired on fork-local pushes. Adding 'master' alongside 'main' makes the full multi-platform build run when master is updated.
… dialog The "Failed to connect to the cloud device server" dialog previously reappeared every time the MQTT connection failed, which was disruptive for users on LAN-only or offline setups. Replace MessageDialog with RichMessageDialog and add a "Don't show this warning again" checkbox. When checked, the config key suppress_cloud_warnings is set to "1" and the dialog is permanently suppressed for future sessions. Closes bambulab#10589
BenJule
force-pushed
the
feat/10589-suppress-cloud-warning
branch
from
f6da686 to
14317b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Failed to connect to the cloud device server" dialog previously reappeared on every MQTT connection failure, which interrupted LAN-only and offline users repeatedly.
Fix: replace
MessageDialogwithRichMessageDialogand add a "Don't show this warning again" checkbox. When the user checks it, the config keysuppress_cloud_warningsis set to"1"and the dialog is permanently suppressed for future sessions.The existing
is_showingre-entrancy guard is preserved, and an early-return reads the config key before showing the dialog.Test plan
suppress_cloud_warnings=1from app config: dialog reappears.Closes #10589