fix: pin Windows CI jobs to windows-2022 until VS 2026 support lands#10863
fix: pin Windows CI jobs to windows-2022 until VS 2026 support lands#10863BenJule wants to merge 1 commit into
Conversation
|
Apologies — this PR was closed by mistake on 2026-06-07, and that was an error on my side, not a deliberate decision to withdraw the change. It happened as an unintended side effect of a branch cleanup in my fork: deleting the head branch automatically closed this PR. The contribution still stands. I have restored the branch and reopened the PR. Sorry for the noise and any confusion this caused. |
|
Updated to fix the Windows build, which is currently broken on every PR. This PR originally pinned the Windows runner to (seen today e.g. on https://github.com/bambulab/BambuStudio/actions/runs/27950300224) Changed the pin to |
|
@lanewei120 when you have a moment, this is currently blocking the Windows build on every open PR.
The macOS half of the same CI breakage (Assimp's bundled zlib vs the macOS 15.5 SDK) is fixed separately in #11051, which is green and ready. Merging both would get CI green across all current PRs again. Thanks! |
|
For reference: my fork's CI already uses So pinning upstream to |
|
I’m working on adding support for Visual Studio 2026 and fixing the related issues. |
|
Thanks Mack, glad VS 2026 support is being picked up properly - that's the right long-term fix and better than the stop-gap here. Just so the context doesn't get lost: this PR pins the Windows jobs back to One thing worth having on your radar for the switch: The rest of this PR is unrelated to the toolchain and fixes CI that's broken on its own: |
6ad1726 to
c5f5e41
Compare
|
Narrowed this PR down to just the |
windows-latest now resolves to the windows-2025-vs2026 image (Visual Studio 2026 / v18 only), so the hardcoded `cmake -G "Visual Studio 17 2022"` fails at configure on every PR. Pin the Windows jobs to windows-2022, which provides VS 2022 17.14 and matches the ..._vs2022.zip deps cache from build_deps.yml. Stop-gap until VS 2026 support lands. Non-Windows CI fixes were split out to bambulab#11277.
c5f5e41 to
db627a3
Compare
Summary
Pin the Windows CI jobs to
windows-2022so the build stops failing on every PR.windows-latestnow resolves to thewindows-2025-vs2026image, which ships Visual Studio 2026 (v18) only - no VS 2022. So the hardcodedcmake -G "Visual Studio 17 2022"fails at configure time:windows-2022still provides Visual Studio Enterprise 2022 (17.14), matching theVisual Studio 17 2022generator and the..._vs2022.zipdeps cache built bybuild_deps.yml. This unblocks the Windows deps + slicer build for all current PRs.This is a stop-gap: @MackBambu is adding proper Visual Studio 2026 support upstream, which will supersede this pin (the
..._vs2022.zipdeps cache will need a matching VS 2026 rebuild at that point).Scope
Narrowed to the Windows-runner pin only. The unrelated CI fixes that were originally bundled here (ubuntu-20.04 removal,
podman buildx,main→masterbranch refs,setup-msbuildv3,winget-releaserpin, brew dedup) are split out to #11277 so they can land independently of the VS work.Test plan
windows-2022(VS 2022 17.14).